Replace nameserver with nameserver
#1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per zonemaster#1353
Note that this PR currently is split into a couple of commits. I'm happy to drop any that are too much.
The last commit renames test files so that they also don't use
nameserverwhich makes it easier to validate thatnameserveris no longer used in the codebase.The two commits preceding the last commit are the user facing/testable changes (which are effectively the core to zonemaster#1353).
There are documentation commits
And the first three commits are effectively typo fixes. -- Note that while they're typo fixes, and all of my commits were written by a script that I use for "spelling" fixes, none of these would be caught by a spell-checker (and certainly not
check-spellingas of yesterday, although tomorrowcheck-spelling/spell-check-this@prereleasewill complain about thea anthing...).I'm happy to rewrite the commit messages (or squash them). The commits here are just the laziest way to start a conversation -- once the project decides how it wants things to be organized, I can reword/reorder/squash the commits.