Make RefactorSession.prototype.replace only count changed nodes #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the following code causes `shift-refactor` to crash (infinite recursion):
[```js
const {parseScript}=require("shift-parser");
const RefactorSession=require("shift-refactor");
const script=`
window['example string with spaces'];
`;
const session=new RefactorSession(parseScript(script));
session.convertComputedToStatic();
```](https://runkit.com/embed/5t8xd3wbw1am)
It happens because `RefactorSession.prototype.convertComputedToStatic` uses `RefactorSession.prototype.replaceRecursive`, and its replacement program returns the original node in certain cases. When the `expression.value` of a `ComputedMemberExpression` or any of its variants contains a space, the function will return the original node (signifying that there should be no replacement). When `RefactorSession.prototype.replace` is run in `RefactorSession.prototype.replaceRecursive`, the nodes that were not replaced are still counted in the number of replacements. This means that even though there are no more nodes to replace, `RefactorSession.prototype.replaceRecursive` runs again. This PR solves the issue by changing `RefactorSession.prototype.replace` to count only changed nodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the following code causes
shift-refactorto crash (infinite recursion):Example code here
It happens because
RefactorSession.prototype.convertComputedToStaticusesRefactorSession.prototype.replaceRecursive, and its replacement program returns the original node in certain cases. When theexpression.valueof aComputedMemberExpressionor any of its variants contains a space, the function will return the original node (signifying that there should be no replacement). WhenRefactorSession.prototype.replaceis run inRefactorSession.prototype.replaceRecursive, the nodes that were not replaced are still counted in the number of replacements. This means that even though there are no more nodes to replace,RefactorSession.prototype.replaceRecursiveruns again. This PR solves the issue by changingRefactorSession.prototype.replaceto count only changed nodes.