-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: semantic-release and circleci #60
base: master
Are you sure you want to change the base?
Conversation
This will move packages to CircleCI. It also adds a "publish" job that will publish the package according to Semantic Release.
a468fdb
to
0e26ce4
Compare
I removed the I also removed the "version" field from package.json because semantic-release automatically adds the appropriate version just before publishing, and doesn't keep the version in git up to date. |
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "jstransformer-foo", | |||
"version": "0.0.0", | |||
"private": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call... We'll have to remember to remove private from the packages that use this. 👍
|
||
## v0.0.1: 2015-xx-xx | ||
|
||
- Initial release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree about the removal of HISTORY.md ... There isn't a real big need for it.
@ForbesLindesay @RobLoach Any chance to get this merged so the rest of the jstransformers can be updated? Perhaps it's an option to rename |
This will move packages to CircleCI. It also adds a "publish" job that will publish the package according to Semantic Release.
This will make it much easier to maintain the packages as there will be a single
jstransformers
account on npm that is responsible for publishing all packages, and all we will need to do is review/merge PRs as appropriate.