Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: semantic-release and circleci #60

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

ForbesLindesay
Copy link
Member

This will move packages to CircleCI. It also adds a "publish" job that will publish the package according to Semantic Release.

This will make it much easier to maintain the packages as there will be a single jstransformers account on npm that is responsible for publishing all packages, and all we will need to do is review/merge PRs as appropriate.

This will move packages to CircleCI. It also adds a "publish" job that will publish the package according to Semantic Release.
@ForbesLindesay
Copy link
Member Author

I removed the HISTORY.md file as semantic-release automatically maintains release notes in the GitHub releases.

I also removed the "version" field from package.json because semantic-release automatically adds the appropriate version just before publishing, and doesn't keep the version in git up to date.

@@ -1,6 +1,6 @@
{
"name": "jstransformer-foo",
"version": "0.0.0",
"private": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call... We'll have to remember to remove private from the packages that use this. 👍


## v0.0.1: 2015-xx-xx

- Initial release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree about the removal of HISTORY.md ... There isn't a real big need for it.

@webketje
Copy link

@ForbesLindesay @RobLoach Any chance to get this merged so the rest of the jstransformers can be updated?
Perhaps the test run fails on Node 8 because xo@0.25.4 is the latest compatible version (output from npm info xo@* engines.node) but package.json has a "xo": "*" dependency?

Perhaps it's an option to rename posttest and enforce the style before the CI runs? (eg with husky)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants