Switch dynamic version handling from pkg_resources (in setuptools) to packaging #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… packaging
This fixes following `ModuleNotFoundError` resulting from missing
dependency on setuptools:
% rye add pygrib --path /path/to/repo
% rye sync
% rye run python -c 'import pygrib'
ModuleNotFoundError: No module named 'pkg_resources'
In the executable code of pygrib, setuptools is only used for version
comparison purposes, and since setuptools is larger than necessary, this
commit replaces it with packaging, which is a more compact module
containing reusable core utilities for Python packaging compliant with
recent PEPs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
ModuleNotFoundErrorresulting from missing dependency on setuptools.In the executable code of pygrib, setuptools is only used for version comparison purposes, and since setuptools is larger than necessary, this commit replaces it with packaging, which is a more compact module containing reusable core utilities for Python packaging compliant with recent PEPs.
Closes #228.