Skip to content

Conversation

mfigard
Copy link

@mfigard mfigard commented Sep 17, 2025

Bug report: #3951

This proposed fix treats JSX fragments like JSX elements when handling the propElementValues option:

  • It checks for unnecessary curly brackets in JSX fragments just like it does in JSX elements
  • It considers JSX fragment when checking and reporting missing curly brackets

Let me know what you think, happy to update the code with any suggestions you have!

Copy link

codecov bot commented Sep 17, 2025

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.78%. Comparing base (f2869fd) to head (94e2467).

Files with missing lines Patch % Lines
lib/rules/jsx-curly-brace-presence.js 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3952      +/-   ##
==========================================
- Coverage   97.84%   97.78%   -0.06%     
==========================================
  Files         136      133       -3     
  Lines       10008     9999       -9     
  Branches     3717     3718       +1     
==========================================
- Hits         9792     9778      -14     
- Misses        216      221       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant