Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good morning Jeremy
I first want to thank you for this very solid program to make Trello backups. I was increasingly fearing a catastrophic failure since I always have more data and more information on Trello, and with your software, I know that a catastrophic failure would still be very bad, but not completely catastrophic :-)
I took the liberty to modify the behaviour of your software when using the tokenize option. First, I think that tokens should be independent on the location of the list, card or attachment. If it isn't (current behaviour), then moving an element around would change its resulting file name or folder, which would result in a duplicata if the backup is launched with the "incremental" option. So I removed the "id_" prefix when using "tokenize".
The next modification is to also use the token for the board name, for a similar reason: changing the board name would break incremental backups and generate duplicate boards, whereas using the token works.
Finally, I changed the backup list folders for use their full id, not just the short url, to be coherent with the other elements that do use the full id.
I understand that it breaks the previous behaviour of your perfectly fine software and I understand it you'd reject this pull request, but I just wanted to give back if this interests you.
Thank you again,
Cordially,
Felix