Skip to content

Conversation

@jturner314
Copy link
Owner

Fixes #84.

@jturner314 jturner314 added the breaking change PRs that break backwards compatibility label Nov 17, 2025
use std::io::{Read, Seek, SeekFrom, Write};
use std::mem;

#[track_caller]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this track_caller?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That way, if the assertion fails, the error message is more useful since the line number in the error message points to the specific line in the test that failed, not the internals of the assert_written_is_correct function. (Regardless, you can see the full backtrace with RUST_BACKTRACE=1 cargo test; it's just more convenient if the output of cargo test without RUST_BACKTRACE is also informative.)

@jturner314 jturner314 marked this pull request as ready for review November 26, 2025 20:17
@jturner314 jturner314 merged commit 8c59bd4 into master Nov 26, 2025
12 checks passed
@jturner314 jturner314 deleted the ndarray-0.17 branch November 26, 2025 20:40
@hacknus
Copy link

hacknus commented Nov 28, 2025

Thanks a lot! can you issue release 0.10 for this? :-)

@jturner314
Copy link
Owner Author

I will. I'd just like to make a few more changes before the next release. I should have time to finish it up next weekend.

@jturner314
Copy link
Owner Author

A few things came up this weekend, so I didn't have as much time as I anticipated. My new plan is to finish up the new release next weekend.

@jturner314
Copy link
Owner Author

I just released version 0.10.0 of ndarray-npy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change PRs that break backwards compatibility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update ndarray to 0.17

4 participants