-
Notifications
You must be signed in to change notification settings - Fork 247
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Simpler, more modern API for listen/notify. (#910)
No more inheritance, no more virtual functions, no more mandatory base class — just pass in a lambda or any other matching callable. Only one handler per channel — makes the channel name the key, and you can disable a handler simply by overwriting it. No more hassle with case-insensitive channel names. We'll just quote them consistently. No more logging of exceptions, to a notice-processing callback which probably just ignores the message. Exceptions during handling now just propagate up the call chain.
- Loading branch information
Showing
17 changed files
with
722 additions
and
179 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
# XXX: Pin versions. | ||
# TODO: Pin versions. | ||
# TODO: Do we even still need this file? | ||
dia | ||
sphinx-rtd-theme | ||
myst-parser |
Oops, something went wrong.