refactor!: Update Jbk and use error_set for our errors #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Last version of Jubako refactors its error system and avoid us to store generic error in jbk's error. (and this is a good thing) Now, waj functions return waj errors which may contain jbk error. All error that can be considered as Waj format error (wrong property...) are now `WajFormatError`, not jbk's `FormatError`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last version of Jubako refactors its error system and avoid us to store generic error in jbk's error. (and this is a good thing)
Now, waj functions return waj errors which may contain jbk error.
All error that can be considered as Waj format error (wrong property...) are now
WajFormatError, not jbk'sFormatError.