This repository was archived by the owner on Apr 2, 2025. It is now read-only.
Make device address an optional parameter#2
Open
ademcaliskan wants to merge 1 commit intojuddflamm:masterfrom
Open
Make device address an optional parameter#2ademcaliskan wants to merge 1 commit intojuddflamm:masterfrom
ademcaliskan wants to merge 1 commit intojuddflamm:masterfrom
Conversation
it as opts parameter during constuction.
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all thanks for the great work!
Some parts of the oled.js file need an update, if you want to use the module with new revs of the pi.
Rev.2 uses a different address -> dev/i2c-1
So I intend to make the device address as an optional paameter with /dev/i2c-0 as default, to preserve backward compatibility.
Thanks.