Skip to content

[Rust] Change some if let Somes that do not use the value #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juharris merged 1 commit into from
Dec 1, 2025
Merged

[Rust] Change some if let Somes that do not use the value #161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions rust/optify/src/provider/provider_impl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ impl OptionsProvider {
cache_options: Option<&CacheOptions>,
preferences: Option<&GetOptionsPreferences>,
) -> Result<serde_json::Value, String> {
if let Some(_cache_options) = cache_options {
if cache_options.is_some() {
match self.get_entire_config_from_cache(feature_names, preferences) {
Ok(Some(config)) => return Ok(config),
Ok(None) => (),
Expand Down Expand Up @@ -114,7 +114,7 @@ impl OptionsProvider {
}
}

if let Some(_cache_options) = cache_options {
if cache_options.is_some() {
let cache_key = feature_names.to_owned();
self.entire_config_cache
.write()
Expand Down Expand Up @@ -404,9 +404,9 @@ impl OptionsRegistry for OptionsProvider {
) -> Result<Vec<String>, String> {
let mut skip_feature_name_conversion = false;
let mut constraints = None;
if let Some(_preferences) = preferences {
skip_feature_name_conversion = _preferences.skip_feature_name_conversion;
constraints = _preferences.constraints.as_ref();
if let Some(preferences) = preferences {
skip_feature_name_conversion = preferences.skip_feature_name_conversion;
constraints = preferences.constraints.as_ref();
}

let mut result = Vec::new();
Expand Down Expand Up @@ -448,7 +448,7 @@ impl OptionsRegistry for OptionsProvider {
cache_options: Option<&CacheOptions>,
preferences: Option<&GetOptionsPreferences>,
) -> Result<serde_json::Value, String> {
if let Some(_cache_options) = cache_options {
if cache_options.is_some() {
match self.get_options_from_cache(key, feature_names, cache_options, preferences) {
Ok(Some(options)) => return Ok(options),
Ok(None) => (),
Expand Down
Loading