Improve detection of debian systems #865
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears, from reading osplatform.py, that Debian should be supported,
however, it's been observed in python3.11 on debian bookworm,
that it raises an error about no debian support (in a zuul test run):
```
debian-bookworm | File "/home/zuul/src/opendev.org/openstack/charm-ceph-iscsi/.tox/py311/lib/python3.11/site-packages/charmhelpers/osplatform.py", line 35, in get_platform
debian-bookworm | raise RuntimeError("This module is not supported on {}."
debian-bookworm | RuntimeError: This module is not supported on Debian GNU/Linux.
```
Improve detection by comparing in a case insensitive manner.
|
Note: on pause, pending discussion over at #862 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears, from reading osplatform.py, that Debian should be supported,
however, it's been observed in python3.11 on debian bookworm,
that it raises an error about no debian support (in a zuul test run):
Improve detection by comparing in a case insensitive manner.
Fixes bug https://bugs.launchpad.net/charm-helpers/+bug/2040958