Drop use of get_os_version_codename_swift [zed backport] #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swift payload upgrades to wallaby or later currently fail because this code is unable to determine the version for wallaby+. For example: FATAL ERROR: Could not derive swift version for codename: wallaby We stopped maintaining the SWIFT_CODENAMES and PACKAGE_CODENAMES as of wallaby because the openstack-release package was introduced in wallaby. We could update the SWIFT_CODENAMES map, but really this map no longer needs to be used. There was a time when the same swift package version existed in two different OpenStack releases, but that is no longer the case [1]. Therefore we can use the same comparison used for OpenStack packages which essentially checks current release (based on the openstack-release package) vs the installation source release. [1] Current swift versions in Ubuntu are: 2.32.0 bobcat 2.31.1 antelope 2.30.1 zed 2.29.2 yoga 2.28.1 xena 2.27.0 wallaby 2.26.0 victoria 2.25.2 ussuri Closes-Bug: #2040606 (cherry picked from commit b604d56)
coreycb
force-pushed
the
swift-version-zed
branch
from
c960d77
to
9d4067e
Compare
(cherry picked from commit 62a356c)
coreycb
force-pushed
the
swift-version-zed
branch
from
9d4067e
to
fa9a836
Compare
freyes
changed the title
openstack-mirroring
pushed a commit
to openstack/charm-swift-proxy
that referenced
this pull request
Dec 1, 2023
Sync charm-helpers to pick up fix for openstack_upgrade_available that enables successful payload upgrades. This will need backporting to stable/wallaby. juju/charm-helpers#868 Closes-Bug: #2040606 Change-Id: Iad443c8485eef6a712873925ae760043be55985c
openstack-mirroring
pushed a commit
to openstack/charm-swift-storage
that referenced
this pull request
Apr 3, 2024
Sync charm-helpers to pick up fix for openstack_upgrade_available that enables successful payload upgrades. This will need backporting to stable/wallaby. juju/charm-helpers#868 Closes-Bug: #2040606 Change-Id: Ie32b745e5857ce37d622f95b957ffdd4cd4aba9d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift payload upgrades to wallaby or later currently fail because this code is unable to determine the version for wallaby+. For example:
FATAL ERROR: Could not derive swift version for codename: wallaby
We stopped maintaining the SWIFT_CODENAMES and PACKAGE_CODENAMES as of wallaby because the openstack-release package was introduced in wallaby.
We could update the SWIFT_CODENAMES map, but really this map no longer needs to be used. There was a time when the same swift package version existed in two different OpenStack releases, but that is no longer the case [1]. Therefore we can use the same comparison used for OpenStack packages which essentially checks current release (based on the openstack-release package) vs the installation source release.
[1] Current swift versions in Ubuntu are:
2.32.0 bobcat
2.31.1 antelope
2.30.1 zed
2.29.2 yoga
2.28.1 xena
2.27.0 wallaby
2.26.0 victoria
2.25.2 ussuri
Closes-Bug: #2040606
(cherry picked from commit b604d56)