Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove app timeout #1018

Merged
merged 5 commits into from
Feb 1, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions juju/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -1000,7 +1000,15 @@ async def remove_storage(self, *storage_ids, force=False, destroy_storage=False)
if ret.results[0].error:
raise JujuError(ret.results[0].error.message)

async def remove_application(self, app_name, block_until_done=False, force=False, destroy_storage=False, no_wait=False):
async def remove_application(
self,
app_name,
block_until_done=False,
force=False,
destroy_storage=False,
no_wait=False,
timeout=None
):
"""Removes the given application from the model.

:param str app_name: Name of the application
Expand All @@ -1009,6 +1017,8 @@ async def remove_application(self, app_name, block_until_done=False, force=False
:param bool no_wait: Rush through application removal without waiting for each individual step to complete (=false)
:param bool block_until_done: Ensure the app is removed from the
model when returned
:param int timeout: Raise asyncio.exceptions.TimeoutError if the application is not removed
within the timeout period.
"""
if app_name not in self.applications:
raise JujuError("Given application doesn't seem to appear in the\
Expand All @@ -1019,7 +1029,7 @@ async def remove_application(self, app_name, block_until_done=False, force=False
no_wait=no_wait,
)
if block_until_done:
await self.block_until(lambda: app_name not in self.applications)
await self.block_until(lambda: app_name not in self.applications, timeout=timeout)

async def block_until(self, *conditions, timeout=None, wait_period=0.5):
"""Return only after all conditions are true.
Expand Down
11 changes: 11 additions & 0 deletions tests/integration/test_application.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
# Licensed under the Apache V2, see LICENCE file for details.

from pathlib import Path
import asyncio

import pytest
import logging
Expand Down Expand Up @@ -324,6 +325,16 @@ async def test_app_remove_wait_flag():
assert a_name not in model.applications


@base.bootstrapped
async def test_app_remove_timeout():
async with base.CleanModel() as model:
app = await model.deploy('ubuntu')
await model.wait_for_idle(status="active")

with pytest.raises(asyncio.TimeoutError):
await model.remove_application(app.name, block_until_done=True, timeout=1)


@base.bootstrapped
async def test_app_charm_name():
async with base.CleanModel() as model:
Expand Down
Loading