Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add melos to project #681

Merged
merged 10 commits into from
May 15, 2024
Merged

Conversation

ThexXTURBOXx
Copy link
Contributor

Using melos makes it much easier to manage multi-module repos such as this.
In order to set everything up, run melos bootstrap in the root directory of this repo and the pubspec_overrides.yaml will automatically be generated.
Publishing new package versions is as easy as running melos publish --no-dry-run (without --no-dry-run it does just a dry run to see if publishing would go smoothly).
You might consider migrating to melos as it will also make your CI much more easy.

If you want me to complete this PR, just let me know and I will properly migrate the CI also.

@ThexXTURBOXx ThexXTURBOXx marked this pull request as draft February 17, 2024 16:45
@ThexXTURBOXx ThexXTURBOXx changed the title Add melos to project WIP: Add melos to project Feb 17, 2024
@juliansteenbakker
Copy link
Owner

@ThexXTURBOXx This looks promising! I would be happy to integrate this. If its possible for you to complete the PR that would be great.

@ThexXTURBOXx ThexXTURBOXx marked this pull request as ready for review May 6, 2024 09:26
@ThexXTURBOXx
Copy link
Contributor Author

@juliansteenbakker Thank you very much for your feedback! I have also migrated the CI and added some documentation about how to set up melos on a local machine - it is very quick to get it running.
I have not tested the CI yet - so there could be some issues. However, as soon as you allow the workflows to run on this PR, we will see if everything works properly!

@ThexXTURBOXx ThexXTURBOXx changed the title WIP: Add melos to project Add melos to project May 6, 2024
@ThexXTURBOXx
Copy link
Contributor Author

@juliansteenbakker Sorry, forgot to add the right paths to the $PATH. Now, it should work :)

@ThexXTURBOXx
Copy link
Contributor Author

I am terribly sorry, I had another typo in the commands - now it should really work

@ThexXTURBOXx
Copy link
Contributor Author

Perfect, now it worked fine! F:\_Coding\flutter_secure_storage\flutter_secure_storage_windows\test\unit_test.dart actually had bad formatting - so I fixed it. Now the formatting check will also pass.
This PR is now ready to get merged! :)

@ThexXTURBOXx
Copy link
Contributor Author

By the way: flutter drive has problems: https://github.com/mogol/flutter_secure_storage/actions/runs/8983183839/job/24672407474?pr=681#step:7:79

According to this SO, you probably need to wait for the GitHub-hosted ARM64 runners. Or is it maybe enough to just specify arch: arm64 or something?
Anyway, this is out of the scope of this PR, I would say... So, yes, feel free to merge this :)

@vicenterusso
Copy link

By the way: flutter drive has problems: https://github.com/mogol/flutter_secure_storage/actions/runs/8983183839/job/24672407474?pr=681#step:7:79

According to this SO, you probably need to wait for the GitHub-hosted ARM64 runners. Or is it maybe enough to just specify arch: arm64 or something? Anyway, this is out of the scope of this PR, I would say... So, yes, feel free to merge this :)

Isar was using macos runners for android integration tests. I changed to ubuntu-latest without problems. Maybe this could be done too?

@juliansteenbakker
Copy link
Owner

I have fixed this issue already on another branch, and will update this asap.

@ThexXTURBOXx
Copy link
Contributor Author

@juliansteenbakker I merged upstream develop again into my branch and also added a workaround for the flakiness of the flutter drive integration test(s).
It is not non-flaky now, but the chances that the tests now fail are extremely low, so it should be fine :)

@juliansteenbakker juliansteenbakker merged commit fd1a688 into juliansteenbakker:develop May 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants