Skip to content

feat: access control android #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

juliansteenbakker
Copy link
Owner

@juliansteenbakker juliansteenbakker commented Feb 4, 2025

Adds biometric control for keystore access on Android

Fixes #615

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.48%. Comparing base (29dae72) to head (8dc4125).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #878   +/-   ##
========================================
  Coverage    61.48%   61.48%           
========================================
  Files            9        9           
  Lines          148      148           
========================================
  Hits            91       91           
  Misses          57       57           
Flag Coverage Δ
unittests 61.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kun19
Copy link

Kun19 commented Feb 6, 2025

Hi,

please see #615 (comment) for a security improvement.

@juliansteenbakker
Copy link
Owner Author

please see #615 (comment) for a security improvement.

Thanks for the headsup, i'm going to implement the changes that the blogpost suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Add Biometric Authentication Process as an Option
3 participants