Stabilize the version of standard

julik · Feb 29, 2024 · 82feb74 · 82feb74
1 parent aadb161
commit 82feb74
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -23,5 +23,7 @@ jobs:
         with:
           ruby-version: ${{ matrix.ruby }}
           bundler-cache: true
-      - name: "Tests and Lint"
-        run: bundle exec rake
+      - name: "Tests"
+        run: bundle exec rspec --backtrace --fail-fast
+      - name: "Lint"
+        run: bundle exec standard
diff --git a/lib/zip_kit/rack_body.rb b/lib/zip_kit/rack_body.rb
@@ -18,8 +18,7 @@
 #       end
 #     end
 #
-# either as a `Transfer-Encoding: chunked` response (if your webserver supports it),
-
+# Either as a `Transfer-Encoding: chunked` response (if your webserver supports it),
 # which will give you true streaming capability:
 #
 #     chunked_body = iterable_zip_body.to_chunked

diff --git a/zip_kit.gemspec b/zip_kit.gemspec
@@ -33,7 +33,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "benchmark-ips"
   spec.add_development_dependency "allocation_stats", "~> 0.1.5"
   spec.add_development_dependency "yard", "~> 0.9"
-  spec.add_development_dependency "standard" # , ">= 0.2.5", "< 0.3" # Since we want to support Ruby 2.6 for the moment
+  spec.add_development_dependency "standard", "1.28.5" # Very specific version of standard for 2.6 with _known_ settings
   spec.add_development_dependency "magic_frozen_string_literal"
   spec.add_development_dependency "puma"
   spec.add_development_dependency "appraisal", "~> 2.5"