Conversation
- 애플리케이션의 에러 코드를 갖는 CustomException 정의 - 모든 애플리케이션 예외가 CustomException을 상속 - ExceptionHandler에서 동일하게 처리
- 불필요한 유스케이스 인터페이스 삭제 - 회원가입, 로그인, 로그아웃을 처리하는 UserService로 통합 - 로그인은 레디스에 세션 저장 및 생성된 세션아이디 반환 - 로그아웃은 세션 삭제 처리
highluck
approved these changes
Jan 6, 2025
highluck
left a comment
highluck
left a comment
There was a problem hiding this comment.
해당 PR은 좋은데
시간 되신다면
oauth 2.0 개념을 활용해서
access token 과 refresh token 개념을 도입해봐도 좋을것 같아요!
https://hudi.blog/oauth-2.0/
|
|
||
| import java.io.Serializable; | ||
|
|
||
| @Getter @Setter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
코드 리팩토링
로그인, 로그아웃 구현