-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spike for expression language evaluation in display names #4293
base: main
Are you sure you want to change the base?
Spike for expression language evaluation in display names #4293
Conversation
…TestMethodContext
…stExtensionTests to TestExtensionContext
…erFormatter so that a custom expression language formatter can be plugged in
…ameFormatter, pull ArgumentsContext up to separate class
|
||
@Override | ||
public void append(ArgumentsContext argumentsContext, StringBuffer result) { | ||
expressionLanguageAdapter.format(argumentsContext.arguments.get()[0], result); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not correct, but I'm unsure how we should name multiple arguments, so that they can be accessed by the EL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've only taken a quick glance, but for starters...
This new feature must be applicable to JUnit Jupiter in general, not just for parameterized tests.
So the APIs need to reside in the junit-jupiter-api
module.
Please revise your work to take that into account.
See also: #1154 (comment)
Overview
@ExpressionLanguage
annotation, that takes aClass<ExpressionLanguageAdapter>
as parameterExpressionLanguageAdapter
interface, that can be implemented to bind in a third-party expression languageExpressionLanguageMustacheTests
, that demonstrate how@ExpressionLanguage / ExpressionLanguageAdapter
can be usedI'm marking this as a draft PR, because it's not entirely clear yet how the API should look like. I'll address the items in the Definition of Done once we have more clarity on that.
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@API
annotations