Only define owrxdone method with IRAM_ATTR in one place #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieucarbou
added a commit
to mathieucarbou/MycilaDS18
that referenced
this pull request
Nov 5, 2025
mathieucarbou
added a commit
to mathieucarbou/MycilaDS18
that referenced
this pull request
Nov 5, 2025
OneWireESP32.cpp
Outdated
| #define OW_SLOT_RECOVERY 5 | ||
| #define OW_TIMEOUT 50 | ||
|
|
||
| IRAM_ATTR bool owrxdone(rmt_channel_handle_t ch, const rmt_rx_done_event_data_t *edata, void *udata); |
There was a problem hiding this comment.
can also be made static and constexpr
Author
There was a problem hiding this comment.
Good point. If you want to push a change, please do! Otherwise I'll do it tomorrow.
There was a problem hiding this comment.
Good point. If you want to push a change, please do! Otherwise I'll do it tomorrow.
I have my own lib, depending on this one (https://github.com/mathieucarbou/MycilaDS18), which adds a more friendly user facing layer for arduino. So I use to watch for the good ideas to cherry pick ;-)
Moves definition to .cpp, as it does not need to be accessible outside this library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves definition to .cpp, as it does not need to be accessible outside this library. This avoids warnings with declaring the attribute in multiple source files.