Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.13 version and remove support for Python 3.7 and 3.8 versions #575

Merged
merged 1 commit into from
Mar 1, 2025

Conversation

asmita-sharma1625
Copy link
Contributor

@asmita-sharma1625 asmita-sharma1625 commented Feb 26, 2025

Adding support for Python 3.13 version and removing support for Python 3.7 and 3.8 versions

References

Resolves #551

Code changes

Following modifications made to the project config in the pyproject.toml file:

  1. Added support for Python 3.13 in the classifiers config.
  2. Removed support for Python 3.7 and 3.8 in the classifiers config.
  3. Upgraded the minimum required python version (requires-python) to 3.9.

User-facing changes

None.

Backwards-incompatible changes

None Anticipated. Awaiting results from CLI tests for further evaluation.

@srdas srdas added dependencies Pull requests that update a dependency file enhancement New feature or request and removed dependencies Pull requests that update a dependency file labels Feb 26, 2025
Copy link
Collaborator

@andrii-i andrii-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work @asmita-sharma1625. Code changes look good. I have a couple of small issue queue / maintenance-related requests before this PR is ready to be merged:

  1. For the sake of clarity please remove issue number from the issue title
  2. Please link the pull request to the issue it would solve https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue

@asmita-sharma1625
Copy link
Contributor Author

Thank you for your work @asmita-sharma1625. Code changes look good. I have a couple of small issue queue / maintenance-related requests before this PR is ready to be merged:

  1. For the sake of clarity please remove issue number from the issue title
  2. Please link the pull request to the issue it would solve https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue

Addressed the comments.

@asmita-sharma1625 asmita-sharma1625 changed the title Add support for Python 3.13 version and remove support for Python 3.7 and 3.8 versions (#551). Add support for Python 3.13 version and remove support for Python 3.7 and 3.8 versions Feb 28, 2025
Copy link
Collaborator

@andrii-i andrii-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@andrii-i andrii-i merged commit 934f1cb into jupyter-server:main Mar 1, 2025
6 checks passed
@asmita-sharma1625 asmita-sharma1625 deleted the py13support branch March 3, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update supported Python versions to include 3.13, remove 3.7 and 3.8
3 participants