Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract out kernels #1106

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions jupyter_server/base/handlers.py
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,14 @@ def contents_manager(self):

@property
def session_manager(self):
if "session_manager" not in self.settings:
self.settings["session_manager"] = self.settings["session_manager_class"](
parent=self.serverapp,
log=self.settings["log"],
kernel_manager=self.settings["kernel_manager"],
contents_manager=self.contents_manager,
)

return self.settings["session_manager"]

@property
Expand Down
8 changes: 4 additions & 4 deletions jupyter_server/base/zmqhandlers.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@
# Raise a warning that this module is deprecated.
import warnings

from tornado.websocket import WebSocketHandler

from jupyter_server.base.websocket import WebSocketMixin
from jupyter_server.services.kernels.connection.base import (
from jupyter_server_kernels.kernels.connection.base import (
deserialize_binary_message,
deserialize_msg_from_ws_v1,
serialize_binary_message,
serialize_msg_to_ws_v1,
)
from tornado.websocket import WebSocketHandler

from jupyter_server.base.websocket import WebSocketMixin

warnings.warn(
"jupyter_server.base.zmqhandlers module is deprecated in Jupyter Server 2.0",
Expand Down
4 changes: 2 additions & 2 deletions jupyter_server/gateway/managers.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@
from jupyter_client.kernelspec import KernelSpecManager
from jupyter_client.manager import AsyncKernelManager
from jupyter_client.managerabc import KernelManagerABC
from jupyter_server_kernels.kernels.kernelmanager import AsyncMappingKernelManager
from jupyter_server_kernels.sessions.sessionmanager import SessionManager
from tornado import web
from tornado.escape import json_decode, json_encode, url_escape, utf8
from traitlets import DottedObjectName, Instance, Type, default

from .._tz import UTC
from ..services.kernels.kernelmanager import AsyncMappingKernelManager
from ..services.sessions.sessionmanager import SessionManager
from ..utils import ensure_async, url_path_join
from .gateway_client import GatewayClient, gateway_request

Expand Down
Empty file.
39 changes: 0 additions & 39 deletions jupyter_server/kernelspecs/handlers.py

This file was deleted.

Loading