-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Logs for get_os_path closes issue #1336
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
Thanks @jayeshsingh9767! It looks like we could put the debug log in the |
@blink1073 Thanks for the Quick Review, initially I too thought so but I was not sure if self.log object is available inside fileio.py will try out logging inside |
The typing failures are unrelated, I'll handle those in a follow up PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Oh actually, the lint is related, ha! I'll push the updates. |
Thanks @blink1073 |
Congrats on closing a 7 years old issue ! 🥳 |
closes issue jupyter/notebook#857
Changes made: added self.log.debug("Reading path from disk: %s", path) in filemanager.py in jupyter_server