Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change jupyterlab version and add yarn dependency #1149

Merged
merged 20 commits into from
Dec 11, 2023
Merged

Change jupyterlab version and add yarn dependency #1149

merged 20 commits into from
Dec 11, 2023

Conversation

gjmooney
Copy link
Contributor

@gjmooney gjmooney commented Dec 4, 2023

No description provided.

martinRenou
martinRenou approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

martinRenou
martinRenou requested changes Dec 5, 2023
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing because the yarn.lock under the ui-tests directory was generated with yarn v1, see https://github.com/jupyter-widgets/ipyleaflet/blob/master/ui-tests/yarn.lock#L2

You need to remove that yarn.lock file and re-generate it with a jlpm install under that directory.

martinRenou
martinRenou requested changes Dec 6, 2023
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the ui-tests/.pnp.cjs, ui-tests/.pnp.loader.mjs and the ui-tests/.yarn cache directory should not be commited.

Instead you should have an .yarnrc.yml file similar to the one under the js directory: https://github.com/jupyter-widgets/ipyleaflet/blob/master/js/.yarnrc.yml

@martinRenou
Copy link
Member

Taking inspiration from the bqplot galata setup

martinRenou
martinRenou requested changes Dec 8, 2023
View reviewed changes
ui-tests/package.json Outdated Show resolved Hide resolved
@martinRenou
Copy link
Member

Bot update galata references

@martinRenou
Copy link
Member

The bot does not work with this. I will update the bot workflow and re-trigger it.

@martinRenou
Copy link
Member

Bot update galata references

1 similar comment
@martinRenou
Copy link
Member

Bot update galata references

@martinRenou
Copy link
Member

Bot update galata references

martinRenou
martinRenou requested changes Dec 11, 2023
View reviewed changes
ui-tests/notebooks/Subitems.ipynb Outdated Show resolved Hide resolved
@martinRenou
Copy link
Member

Bot update galata references

martinRenou
martinRenou reviewed Dec 11, 2023
View reviewed changes
ui-tests/tests/ipyleaflet.test.ts-snapshots/dark--Subitems-ipynb-cell-0-linux.png Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! Back to normal 🚀

@martinRenou
Copy link
Member

Triggering CI

@martinRenou martinRenou reopened this Dec 11, 2023
martinRenou
martinRenou approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@martinRenou martinRenou merged commit b6ac034 into jupyter-widgets:master Dec 11, 2023
3 of 4 checks passed
@gjmooney gjmooney deleted the env_update branch December 18, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gjmooney @martinRenou