Skip to content

Fix emscripten build #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 8, 2024
Merged

Fix emscripten build #36

merged 6 commits into from
Jan 8, 2024

Conversation

IsabelParedes
Copy link
Member

@IsabelParedes IsabelParedes commented Jan 8, 2024 •
edited
Loading

This PR

  • fixes build errors when using emscripten, and
  • updates the CI to match the template

@IsabelParedes
Copy link
Member Author

WASM builds fail with emsdk<=3.1.32

wasm-ld: error: function signature mismatch: _embind_register_class_function
>>> defined as (i32, i32, i32, i32, i32, i32, i32, i32) -> void in

@IsabelParedes IsabelParedes marked this pull request as ready for review January 8, 2024 13:02
@DerThorsten
Copy link
Member

lets just use 3.1.45, this is what we use for emscripten-forge

@DerThorsten DerThorsten merged commit 62a3692 into jupyter-xeus:main Jan 8, 2024
@DerThorsten
Copy link
Member

thank you!

@IsabelParedes IsabelParedes deleted the emscripten branch February 5, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IsabelParedes @DerThorsten