Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the deploy step #2

Closed
jtpio opened this issue Jan 19, 2024 · 2 comments
Closed

Fix the deploy step #2

jtpio opened this issue Jan 19, 2024 · 2 comments

Comments

@jtpio
Copy link
Member

jtpio commented Jan 19, 2024

As noticed in #1 (comment), the deploy step failed when opening a PR from a fork:

image

Maybe the workflow can be adjusted to put the if: condition earlier in the workflow definition.
@jtpio jtpio mentioned this issue Jan 19, 2024
Merged
@DerThorsten
Copy link
Member

done in #9

@jtpio
Copy link
Member Author

jtpio commented Jan 26, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jtpio @DerThorsten