Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jupyter-server and notebook to the build environment #1

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jan 19, 2024

This should help fix the missing contents in the deployed site: https://derthorsten.github.io/xeus-javascript/lab/index.html

As noticed in https://github.com/DerThorsten/xeus-javascript/actions/runs/7583515865/job/20655314743

image

The notebook dependency should bring the following UI items to switch between lab and notebook:

image

@DerThorsten DerThorsten marked this pull request as ready for review January 19, 2024 13:13
@jtpio
Copy link
Member Author

jtpio commented Jan 19, 2024

@DerThorsten looks like the workflow may have some issues for the deploy step: https://github.com/DerThorsten/xeus-javascript/blob/main/.github/workflows/main.yml

Maybe it's because my fork does not have the github-pages environment.

@jtpio
Copy link
Member Author

jtpio commented Jan 19, 2024

But this can be addressed separately.

Looking good when checking the built artifact:

image

@DerThorsten DerThorsten merged commit 5045da3 into jupyter-xeus:main Jan 19, 2024
2 of 3 checks passed
@jtpio jtpio mentioned this pull request Jan 19, 2024
@jtpio jtpio deleted the add-deps branch January 19, 2024 14:21
@jtpio
Copy link
Member Author

jtpio commented Jan 19, 2024

But this can be addressed separately.

Opened #2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants