Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken image scaling in case a custom width or height is provided for the image #2094

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

AndSte01
Copy link
Contributor

@AndSte01 AndSte01 commented Jan 9, 2024

With the current implementation, if a custom image width or height is specified

![alt](./some/img.png){ width=80% }

the image gets distorted during pdf export.

This pull request fixes the issue. It doesn't interfere with the feature that prevents images from overflowing the page.

Before:
grafik

After:
grafik

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 added the bug label Jan 10, 2024
@blink1073 blink1073 merged commit fa8a2de into jupyter:main Jan 10, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants