Do not display mathjax overlay #2181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds reasonable, should we undraft this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a possible race condition when using e.g. webpdf, or when generating html outputs and then attempting to screenshot them or print as pdf, due to the MathJax overlay. This means the MathJax loading overlay can sometimes be included in the final output asset (e.g. in the PDF itself). This is definitely unexpected behavior!
Here I am refreshing the html output, and you can see the MathJax loading bar.
In this PR, I disable this loading bar. I'm not sure if anyone is relying on this loading bar, and to be honest I don't see a ton of value in it, but open to changes or making it parameterized.