Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the check_release.yml to its own workflow #2191

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Move the check_release.yml to its own workflow #2191

wants to merge 3 commits into from

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Nov 14, 2024 •
edited
Loading

  • Move the check_release step to a separate workflow, so it's easier to see if it passes
  • And add an extra step to upload the artifacts built by the releaser, so it's easier to test PRs locally by installing the built wheel from a branch.

@jtpio jtpio changed the title Create check-release.yml Move the check_release.yml to its own workflow Nov 14, 2024
@jtpio jtpio closed this Nov 14, 2024
@jtpio jtpio reopened this Nov 14, 2024
@jtpio jtpio marked this pull request as ready for review November 14, 2024 10:21
@jtpio
Copy link
Member Author

jtpio commented Dec 6, 2024

@martinRenou I was wondering if this was maybe ready to be merged?

Having the built artifacts could help test changes from other PRs more easily, for example #2178.

martinRenou
martinRenou approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou enabled auto-merge (squash) December 6, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtpio @martinRenou