Skip to content

Add the file filter button to the file browser toolbar #2133

Add the file filter button to the file browser toolbar

Add the file filter button to the file browser toolbar #2133

Triggered via pull request October 15, 2024 19:04
Status Failure
Total duration 10m 49s
Artifacts 8

ui-tests.yml

on: pull_request
Matrix: ui-tests
Fit to window
Zoom out
Zoom in

Annotations

13 errors and 4 notices
[firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file: ui-tests/test/filebrowser.spec.ts#L39
1) [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ──────────────────── Error: expect(locator).toBeVisible() Locator: getByRole('toolbar').getByText('Download') Expected: visible Received: hidden Call log: - expect.toBeVisible with timeout 5000ms - waiting for getByRole('toolbar').getByText('Download') 37 | 38 | ['Rename', 'Delete', 'Open', 'Download', 'Delete'].forEach(async (text) => { > 39 | expect(toolbar.getByText(text)).toBeVisible(); | ^ 40 | }); 41 | }); 42 | at forEach (/home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:39:39) at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:38:56
[firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders: ui-tests/test/filebrowser.spec.ts#L55
2) [firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders ─────────── Error: expect(locator).toBeVisible() Locator: getByRole('toolbar').getByText('Delete') Expected: visible Received: hidden Call log: - expect.toBeVisible with timeout 5000ms - waiting for getByRole('toolbar').getByText('Delete') 53 | expect(toolbar.getByText('Rename')).toBeHidden(); 54 | expect(toolbar.getByText('Open')).toBeHidden(); > 55 | expect(toolbar.getByText('Delete')).toBeVisible(); | ^ 56 | }); 57 | 58 | test('Select files and open', async ({ page, tmpPath }) => { at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:55:41
[firefox] › test/mobile.spec.ts:30:7 › Mobile › The layout should be more compact on the file browser page: ui-tests/test/mobile.spec.ts#L38
1) [firefox] › test/mobile.spec.ts:30:7 › Mobile › The layout should be more compact on the file browser page Error: Screenshot comparison failed: 674 pixels (ratio 0.01 of all image pixels) are different. Expected: /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts-snapshots/tree-firefox-linux.png Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-60036-ct-on-the-file-browser-page-firefox/tree-actual.png Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-60036-ct-on-the-file-browser-page-firefox/tree-diff.png 36 | await page.waitForSelector('#top-panel-wrapper', { state: 'hidden' }); 37 | > 38 | expect(await page.screenshot()).toMatchSnapshot('tree.png', { | ^ 39 | maxDiffPixels: 300, 40 | }); 41 | }); at /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts:38:37
[firefox] › test/mobile.spec.ts:30:7 › Mobile › The layout should be more compact on the file browser page: ui-tests/test/mobile.spec.ts#L38
1) [firefox] › test/mobile.spec.ts:30:7 › Mobile › The layout should be more compact on the file browser page Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Error: Screenshot comparison failed: 866 pixels (ratio 0.01 of all image pixels) are different. Expected: /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts-snapshots/tree-firefox-linux.png Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-60036-ct-on-the-file-browser-page-firefox-retry1/tree-actual.png Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-60036-ct-on-the-file-browser-page-firefox-retry1/tree-diff.png 36 | await page.waitForSelector('#top-panel-wrapper', { state: 'hidden' }); 37 | > 38 | expect(await page.screenshot()).toMatchSnapshot('tree.png', { | ^ 39 | maxDiffPixels: 300, 40 | }); 41 | }); at /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts:38:37
[firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file: ui-tests/test/filebrowser.spec.ts#L39
2) [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ──────────────────── Error: expect(locator).toBeVisible() Locator: getByRole('toolbar').getByText('Download') Expected: visible Received: hidden Call log: - expect.toBeVisible with timeout 5000ms - waiting for getByRole('toolbar').getByText('Download') 37 | 38 | ['Rename', 'Delete', 'Open', 'Download', 'Delete'].forEach(async (text) => { > 39 | expect(toolbar.getByText(text)).toBeVisible(); | ^ 40 | }); 41 | }); 42 | at forEach (/home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:39:39) at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:38:56
ui-tests (firefox)
Process completed with exit code 1.
[chromium] › test/notebook.spec.ts:32:7 › Notebook › Renaming the notebook should be possible: ui-tests/test/notebook.spec.ts#L1
1) [chromium] › test/notebook.spec.ts:32:7 › Notebook › Renaming the notebook should be possible ─ Test timeout of 60000ms exceeded.
[chromium] › test/notebook.spec.ts:32:7 › Notebook › Renaming the notebook should be possible: ui-tests/test/notebook.spec.ts#L52
1) [chromium] › test/notebook.spec.ts:32:7 › Notebook › Renaming the notebook should be possible ─ Error: proxy.waitForNavigation: Test timeout of 60000ms exceeded. =========================== logs =========================== waiting for navigation until "load" ============================================================ 50 | await page.click('text="Rename"'), 51 | // wait until the URL is updated > 52 | await page.waitForNavigation(), | ^ 53 | ]); 54 | 55 | // Check the URL contains the new name at /home/runner/work/notebook/notebook/ui-tests/test/notebook.spec.ts:52:18
[chromium] › test/mobile.spec.ts:30:7 › Mobile › The layout should be more compact on the file browser page: ui-tests/test/mobile.spec.ts#L38
1) [chromium] › test/mobile.spec.ts:30:7 › Mobile › The layout should be more compact on the file browser page Error: Screenshot comparison failed: 384 pixels (ratio 0.01 of all image pixels) are different. Expected: /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts-snapshots/tree-chromium-linux.png Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-60036-ct-on-the-file-browser-page-chromium/tree-actual.png Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-60036-ct-on-the-file-browser-page-chromium/tree-diff.png 36 | await page.waitForSelector('#top-panel-wrapper', { state: 'hidden' }); 37 | > 38 | expect(await page.screenshot()).toMatchSnapshot('tree.png', { | ^ 39 | maxDiffPixels: 300, 40 | }); 41 | }); at /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts:38:37
[chromium] › test/mobile.spec.ts:30:7 › Mobile › The layout should be more compact on the file browser page: ui-tests/test/mobile.spec.ts#L38
1) [chromium] › test/mobile.spec.ts:30:7 › Mobile › The layout should be more compact on the file browser page Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Error: Screenshot comparison failed: 384 pixels (ratio 0.01 of all image pixels) are different. Expected: /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts-snapshots/tree-chromium-linux.png Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-60036-ct-on-the-file-browser-page-chromium-retry1/tree-actual.png Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-60036-ct-on-the-file-browser-page-chromium-retry1/tree-diff.png 36 | await page.waitForSelector('#top-panel-wrapper', { state: 'hidden' }); 37 | > 38 | expect(await page.screenshot()).toMatchSnapshot('tree.png', { | ^ 39 | maxDiffPixels: 300, 40 | }); 41 | }); at /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts:38:37
[chromium] › test/links.spec.ts:21:7 › Local Links › Open the current directory: ui-tests/test/links.spec.ts#L1
2) [chromium] › test/links.spec.ts:21:7 › Local Links › Open the current directory ─────────────── Test timeout of 60000ms exceeded.
[chromium] › test/links.spec.ts:21:7 › Local Links › Open the current directory: ui-tests/test/links.spec.ts#L25
2) [chromium] › test/links.spec.ts:21:7 › Local Links › Open the current directory ─────────────── Error: proxy.waitForEvent: Test timeout of 60000ms exceeded. =========================== logs =========================== waiting for event "popup" ============================================================ 23 | 24 | const [current] = await Promise.all([ > 25 | page.waitForEvent('popup'), | ^ 26 | page.getByText('Current Directory').last().click(), 27 | ]); 28 | at /home/runner/work/notebook/notebook/ui-tests/test/links.spec.ts:25:12
ui-tests (chromium)
Process completed with exit code 1.
🎭 Playwright Run Summary
2 flaky [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ───────────────────── [firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders ──────────── 33 passed (2.1m)
🎭 Playwright Run Summary
1 failed [firefox] › test/mobile.spec.ts:30:7 › Mobile › The layout should be more compact on the file browser page 1 flaky [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ───────────────────── 33 passed (2.1m)
🎭 Playwright Run Summary
1 flaky [chromium] › test/notebook.spec.ts:32:7 › Notebook › Renaming the notebook should be possible ── 34 passed (2.1m)
🎭 Playwright Run Summary
1 failed [chromium] › test/mobile.spec.ts:30:7 › Mobile › The layout should be more compact on the file browser page 1 flaky [chromium] › test/links.spec.ts:21:7 › Local Links › Open the current directory ──────────────── 33 passed (2.2m)

Artifacts

Produced during runtime
Name Size
notebook-chromium-test-assets
2.24 MB
notebook-chromium-test-report
2.87 MB
notebook-chromium-updated-snapshots
312 KB
notebook-dist-2133
9.5 MB
notebook-firefox-test-assets
1.06 MB
notebook-firefox-test-report
1.71 MB
notebook-firefox-updated-snapshots
365 KB
notebook-pkgs-2133
57 KB