Skip to content

Add missing "Open..." file menu #2051

Add missing "Open..." file menu

Add missing "Open..." file menu #2051

Re-run triggered May 30, 2024 11:30
Status Failure
Total duration 5m 54s
Artifacts 10

ui-tests.yml

on: pull_request
Matrix: ui-tests
Fit to window
Zoom out
Zoom in

Annotations

9 errors and 3 notices
[chromium] › test/links.spec.ts:21:7 › Local Links › Open the current directory: ui-tests/test/links.spec.ts#L1
1) [chromium] › test/links.spec.ts:21:7 › Local Links › Open the current directory ─────────────── Test timeout of 60000ms exceeded.
[chromium] › test/links.spec.ts:21:7 › Local Links › Open the current directory: ui-tests/test/links.spec.ts#L25
1) [chromium] › test/links.spec.ts:21:7 › Local Links › Open the current directory ─────────────── Error: proxy.waitForEvent: Test timeout of 60000ms exceeded. =========================== logs =========================== waiting for event "popup" ============================================================ 23 | 24 | const [current] = await Promise.all([ > 25 | page.waitForEvent('popup'), | ^ 26 | page.getByText('Current Directory').last().click(), 27 | ]); 28 | at /home/runner/work/notebook/notebook/ui-tests/test/links.spec.ts:25:12
[firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file: ui-tests/test/filebrowser.spec.ts#L39
1) [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ──────────────────── Error: expect(locator).toBeVisible() Locator: getByRole('toolbar').getByText('Download') Expected: visible Received: hidden Call log: - expect.toBeVisible with timeout 5000ms - waiting for getByRole('toolbar').getByText('Download') 37 | 38 | ['Rename', 'Delete', 'Open', 'Download', 'Delete'].forEach(async (text) => { > 39 | expect(toolbar.getByText(text)).toBeVisible(); | ^ 40 | }); 41 | }); 42 | at forEach (/home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:39:39) at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:38:56
[firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders: ui-tests/test/filebrowser.spec.ts#L55
2) [firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders ─────────── Error: expect(locator).toBeVisible() Locator: getByRole('toolbar').getByText('Delete') Expected: visible Received: hidden Call log: - expect.toBeVisible with timeout 5000ms - waiting for getByRole('toolbar').getByText('Delete') 53 | expect(toolbar.getByText('Rename')).toBeHidden(); 54 | expect(toolbar.getByText('Open')).toBeHidden(); > 55 | expect(toolbar.getByText('Delete')).toBeVisible(); | ^ 56 | }); 57 | 58 | test('Select files and open', async ({ page, tmpPath }) => { at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:55:41
[firefox] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item File: ui-tests/test/menus.spec.ts#L47
1) [firefox] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item File ──────────────────── Error: Screenshot comparison failed: 1 pixels (ratio 0.01 of all image pixels) are different. Expected: /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts-snapshots/opened-menu-file-firefox-linux.png Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-File-firefox/opened-menu-file-actual.png Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-File-firefox/opened-menu-file-diff.png 45 | const menu = await page.menu.getOpenMenu(); 46 | expect(menu).toBeDefined(); > 47 | expect(await menu?.screenshot()).toMatchSnapshot(imageName.toLowerCase()); | ^ 48 | }); 49 | }); 50 | }); at /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts:47:40
[firefox] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item File: ui-tests/test/menus.spec.ts#L47
1) [firefox] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item File ──────────────────── Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Error: Screenshot comparison failed: 1 pixels (ratio 0.01 of all image pixels) are different. Expected: /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts-snapshots/opened-menu-file-firefox-linux.png Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-File-firefox-retry1/opened-menu-file-actual.png Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-File-firefox-retry1/opened-menu-file-diff.png 45 | const menu = await page.menu.getOpenMenu(); 46 | expect(menu).toBeDefined(); > 47 | expect(await menu?.screenshot()).toMatchSnapshot(imageName.toLowerCase()); | ^ 48 | }); 49 | }); 50 | }); at /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts:47:40
[firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file: ui-tests/test/filebrowser.spec.ts#L39
2) [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ──────────────────── Error: expect(locator).toBeVisible() Locator: getByRole('toolbar').getByText('Open') Expected: visible Received: hidden Call log: - expect.toBeVisible with timeout 5000ms - waiting for getByRole('toolbar').getByText('Open') 37 | 38 | ['Rename', 'Delete', 'Open', 'Download', 'Delete'].forEach(async (text) => { > 39 | expect(toolbar.getByText(text)).toBeVisible(); | ^ 40 | }); 41 | }); 42 | at forEach (/home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:39:39) at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:38:56
[firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders: ui-tests/test/filebrowser.spec.ts#L55
3) [firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders ─────────── Error: expect(locator).toBeVisible() Locator: getByRole('toolbar').getByText('Delete') Expected: visible Received: hidden Call log: - expect.toBeVisible with timeout 5000ms - waiting for getByRole('toolbar').getByText('Delete') 53 | expect(toolbar.getByText('Rename')).toBeHidden(); 54 | expect(toolbar.getByText('Open')).toBeHidden(); > 55 | expect(toolbar.getByText('Delete')).toBeVisible(); | ^ 56 | }); 57 | 58 | test('Select files and open', async ({ page, tmpPath }) => { at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:55:41
ui-tests (firefox)
Process completed with exit code 1.
🎭 Playwright Run Summary
1 flaky [chromium] › test/links.spec.ts:21:7 › Local Links › Open the current directory ──────────────── 34 passed (2.1m)
🎭 Playwright Run Summary
2 flaky [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ───────────────────── [firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders ──────────── 33 passed (2.0m)
🎭 Playwright Run Summary
1 failed [firefox] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item File ───────────────────── 2 flaky [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ───────────────────── [firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders ──────────── 32 passed (2.2m)

Artifacts

Produced during runtime
Name Size
notebook-firefox-test-assets Expired
2.04 MB
notebook-firefox-test-report Expired
2.63 MB
notebook-firefox-updated-snapshots Expired
360 KB