-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
* Added Edit Notebook Metadata Option (#6402) Edit Notebook Metadata plugin added under Edit Menu for functionality similar to classic-notebook. Clicking on the option under the menu opens up the Notebook Tools widget in the right sidebar and expands the Additional Tools (which contains the Notebook Metadata editor) collapsible section (default: collapsed). * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Added Edit Notebook Metadata Option (#6402) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Prettier Code for passing Test Lint check * Prettier Code for passing Test Lint check * adding the edit-notebook-metadata entry via schema adding the menu entry via the settings defined in the schema folder dropping the dependency on IMainMenu in the plugin * adding the edit-notebook-metadata entry via schema adding the menu entry via the settings defined in the schema folder dropping the dependency on IMainMenu in the plugin * adding the edit-notebook-metadata entry via schema * adding the edit-notebook-metadata entry via schema * adding the edit-notebook-metadata entry via schema * fix menu item * Add to the command palette * Update Playwright Snapshots * Update Playwright Snapshots * fix snapshots --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
- Loading branch information
1 parent
1d0a402
commit 2d717f5
Showing
4 changed files
with
98 additions
and
0 deletions.
There are no files selected for viewing
28 changes: 28 additions & 0 deletions
28
packages/notebook-extension/schema/edit-notebook-metadata.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
{ | ||
"title": "Jupyter Notebook Menu Entries", | ||
"description": "Jupyter Notebook Menu Entries", | ||
"jupyter.lab.menus": { | ||
"main": [ | ||
{ | ||
"id": "jp-mainmenu-edit", | ||
"items": [ | ||
{ | ||
"type": "separator", | ||
"rank": 8.5 | ||
}, | ||
{ | ||
"command": "notebook:edit-metadata", | ||
"rank": 8.5 | ||
}, | ||
{ | ||
"type": "separator", | ||
"rank": 8.5 | ||
} | ||
] | ||
} | ||
] | ||
}, | ||
"properties": {}, | ||
"additionalProperties": false, | ||
"type": "object" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+304 Bytes
(100%)
ui-tests/test/menus.spec.ts-snapshots/opened-menu-edit-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.94 KB
(120%)
ui-tests/test/menus.spec.ts-snapshots/opened-menu-edit-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.