close proxied websockets when upstream sends a regular response #598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
force-pushed
the
bandaid-upstream-close
branch
from
791f012 to
459335d
Compare
|
jupyterhub helm folks can test this by setting: proxy:
chp:
image:
name: ghcr.io/minrk/configurable-http-proxy
tag: pr598I'll also recommend folks exploring this (whether testing the image or not) to set the env chp:
extraEnv:
DEBUG: "http-proxy-3:ws-incoming"which has some really nice logging of how many open sockets are around |
|
@minrk is this PR still relevant or not? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a band-aid for #557
the 'true' fix ought to be sagemathinc/http-proxy-3#27
I don't think we should merge this, I'm just showing folks what it looks like, in case anyone wants to test this before the release is available