Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user was added on sign-up even if password didn't match confirmation #275

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Fix user was added on sign-up even if password didn't match confirmation #275

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
32d3843
Fix user was added on sign-up even if password didn't match confirmation
paolocarinci Jul 27, 2024
2760f19
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 27, 2024
7e5e197
Better fix for mismatching passwords on signup
Jul 27, 2024
c4d38f5
Ensure variables are initialized before use
consideRatio Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions nativeauthenticator/handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,28 +164,28 @@ async def post(self):
else:
self.authenticator.log.error("Failed reCaptcha")

if assume_user_is_human:
user_info = {
"username": self.get_body_argument("username", strip=False),
"password": self.get_body_argument("signup_password", strip=False),
"email": self.get_body_argument("email", "", strip=False),
"has_2fa": bool(self.get_body_argument("2fa", "", strip=False)),
}
username_already_taken = self.authenticator.user_exists(
user_info["username"]
)
Comment on lines -174 to -176
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check is now always done which I think is perfectly fine in this case.

user = self.authenticator.create_user(**user_info)
else:
username_already_taken = False
user = None

# Collect various information for precise (error) messages.
# initialize user_info
user_info = {
"username": self.get_body_argument("username", strip=False),
"password": self.get_body_argument("signup_password", strip=False),
"email": self.get_body_argument("email", "", strip=False),
"has_2fa": bool(self.get_body_argument("2fa", "", strip=False)),
}
username = user_info["username"]

# summarize info
password = self.get_body_argument("signup_password", strip=False)
confirmation = self.get_body_argument(
"signup_password_confirmation", strip=False
)
confirmation_matches = password == confirmation
user_is_admin = user_info["username"] in self.authenticator.admin_users
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user_info wasn't set before if re-captcha had failed (assume_user_is_human=False), so this is fixed now as well.

user_is_admin = username in self.authenticator.admin_users
username_already_taken = self.authenticator.user_exists(username)

# if everything seems ok, create a user
user = None
if assume_user_is_human and not username_already_taken and confirmation_matches:
user = self.authenticator.create_user(**user_info)

# Call helper function from above for precise alert-level and message.
alert, message = self.get_result_message(
Expand Down