-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Update to JupyterLab 4 #1340
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jtpio! This looks good to me. I think the following are breaking-ish changes:
- jupyter-server version to 2.x (how much of a breaking change is this?)
- Support for python 3.7 in the base environment is now gone. How does this affect repos that specify python 3.7?
- jupyterlab to 4.x (so some extensions would break)
I don't fully understand (2), but otherwise with labeling this looks good to me.
The default repo2docker/repo2docker/buildpacks/base.py Line 194 in f667caf
Python 3.7 reached end of life in June 2023: jupyterlab/jupyterlab#13745. JupyterLab 4 requires Python 3.8 now.
Yes, although many have been updated now: jupyterlab/jupyterlab#14590 Also JupyterLab 3 will reach end of maintenance soon: jupyterlab/jupyterlab#15921 |
They are unaffected at the moment. As this PR stands, 3.7 stops getting updates, but continues to be supported for the server environment. The next stage of reduced support is bumping kernel_env_cutoff_version to 3.8, at which point 3.7 becomes a 'kernel-only' version, like 3.6 and older. I think would be reasonable to make this change here as well, but not required. Pro bumping kernel_env_cutoff:
Con:
Since there is no visible effect on 3.7 repos, I think it's fine to merge this as-is. |
This may break users who are installing extensions which aren't compatible with JupyterLab 3. I think we should make an announcement on https://discourse.jupyter.org before merging. |
Extract the part of #1302 to update to JupyterLab 4, without the Notebook 7 update.