Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure internal classes used for style :host(.<class>) are not overridden by className #117

Merged
merged 1 commit into from
Jul 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/react-components/lib/Checkbox.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,18 @@ export const Checkbox = forwardRef((props, forwardedRef) => {
/** Methods - uses `useImperativeHandle` hook to pass ref to component */
useImperativeHandle(forwardedRef, () => ref.current, [ref.current]);

// Add web component internal classes on top of `className`
let allClasses = className ?? '';
if (ref.current?.indeterminate) {
allClasses += ' indeterminate';
}

return React.createElement(
'jp-checkbox',
{
ref,
...filteredProps,
class: props.className,
class: allClasses.trim(),
exportparts: props.exportparts,
for: props.htmlFor,
part: props.part,
Expand Down
8 changes: 7 additions & 1 deletion packages/react-components/lib/DataGridCell.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,20 @@ export const DataGridCell = forwardRef((props, forwardedRef) => {
/** Methods - uses `useImperativeHandle` hook to pass ref to component */
useImperativeHandle(forwardedRef, () => ref.current, [ref.current]);

// Add web component internal classes on top of `className`
let allClasses = className ?? '';
if (ref.current?.cellType === 'columnheader') {
allClasses += ' column-header';
}

return React.createElement(
'jp-data-grid-cell',
{
ref,
...filteredProps,
'cell-type': props.cellType || props['cell-type'],
'grid-column': props.gridColumn || props['grid-column'],
class: props.className,
class: allClasses.trim(),
exportparts: props.exportparts,
for: props.htmlFor,
part: props.part,
Expand Down
10 changes: 9 additions & 1 deletion packages/react-components/lib/DataGridRow.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,14 @@ export const DataGridRow = forwardRef((props, forwardedRef) => {
/** Methods - uses `useImperativeHandle` hook to pass ref to component */
useImperativeHandle(forwardedRef, () => ref.current, [ref.current]);

// Add web component internal classes on top of `className`
let allClasses = className ?? '';
if (ref.current) {
if (ref.current.rowType !== 'default') {
allClasses += ` ${ref.current.rowType}`;
}
}

return React.createElement(
'jp-data-grid-row',
{
Expand All @@ -46,7 +54,7 @@ export const DataGridRow = forwardRef((props, forwardedRef) => {
'grid-template-columns':
props.gridTemplateColumns || props['grid-template-columns'],
'row-type': props.rowType || props['row-type'],
class: props.className,
class: allClasses.trim(),
exportparts: props.exportparts,
for: props.htmlFor,
part: props.part,
Expand Down
11 changes: 10 additions & 1 deletion packages/react-components/lib/MenuItem.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,22 @@ export const MenuItem = forwardRef((props, forwardedRef) => {
/** Methods - uses `useImperativeHandle` hook to pass ref to component */
useImperativeHandle(forwardedRef, () => ref.current, [ref.current]);

// Add web component internal classes on top of `className`
let allClasses = className ?? '';
if (ref.current) {
allClasses += ` indent-${ref.current.startColumnCount}`;
if (ref.current.expanded) {
allClasses += ' expanded';
}
}

return React.createElement(
'jp-menu-item',
{
ref,
...filteredProps,
role: props.role,
class: props.className,
class: allClasses.trim(),
exportparts: props.exportparts,
for: props.htmlFor,
part: props.part,
Expand Down
8 changes: 7 additions & 1 deletion packages/react-components/lib/SliderLabel.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,19 @@ export const SliderLabel = forwardRef((props, forwardedRef) => {
/** Methods - uses `useImperativeHandle` hook to pass ref to component */
useImperativeHandle(forwardedRef, () => ref.current, [ref.current]);

// Add web component internal classes on top of `className`
let allClasses = className ?? '';
if (ref.current?.disabled) {
allClasses += ' disabled';
}

return React.createElement(
'jp-slider-label',
{
ref,
...filteredProps,
position: props.position,
class: props.className,
class: allClasses.trim(),
exportparts: props.exportparts,
for: props.htmlFor,
part: props.part,
Expand Down
8 changes: 7 additions & 1 deletion packages/react-components/lib/Tab.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,18 @@ export const Tab = forwardRef((props, forwardedRef) => {
/** Methods - uses `useImperativeHandle` hook to pass ref to component */
useImperativeHandle(forwardedRef, () => ref.current, [ref.current]);

// Add web component internal classes on top of `className`
let allClasses = className ?? '';
if (ref.current?.classList.contains('vertical')) {
allClasses += ' vertical';
}

return React.createElement(
'jp-tab',
{
ref,
...filteredProps,
class: props.className,
class: allClasses.trim(),
exportparts: props.exportparts,
for: props.htmlFor,
part: props.part,
Expand Down
15 changes: 8 additions & 7 deletions packages/react-components/lib/TreeItem.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,7 @@ import {
jpTreeItem,
provideJupyterDesignSystem
} from '@jupyter/web-components';
import React, {
forwardRef,
useEffect,
useImperativeHandle,
useRef
} from 'react';
import React, { forwardRef, useImperativeHandle, useRef } from 'react';
import { useEventListener, useProperties } from './react-utils.js';
provideJupyterDesignSystem().register(jpTreeItem());

Expand All @@ -27,12 +22,18 @@ export const TreeItem = forwardRef((props, forwardedRef) => {
/** Methods - uses `useImperativeHandle` hook to pass ref to component */
useImperativeHandle(forwardedRef, () => ref.current, [ref.current]);

// Add web component internal classes on top of `className`
let allClasses = className ?? '';
if (ref.current?.nested) {
allClasses += ' nested';
}

return React.createElement(
'jp-tree-item',
{
ref,
...filteredProps,
class: props.className,
class: allClasses.trim(),
exportparts: props.exportparts,
for: props.htmlFor,
part: props.part,
Expand Down
6 changes: 0 additions & 6 deletions packages/react-components/lib/TreeView.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,6 @@ export const TreeView = forwardRef((props, forwardedRef) => {
const { className, renderCollapsedNodes, currentSelected, ...filteredProps } =
props;

useLayoutEffect(() => {
// Fix using private API to force refresh of nested flag on
// first level of tree items.
ref.current?.setItems();
}, [ref.current]);

/** Properties - run whenever a property has changed */
useProperties(ref, 'currentSelected', props.currentSelected);

Expand Down
Loading