-
-
Notifications
You must be signed in to change notification settings - Fork 46
Conversation
Since
From https://github.com/jupyterlab/retrolab/runs/4867923562?check_suite_focus=true |
Let's add notebook_shim to this PR to replace nbclassic. |
Done in 2435634 |
Next step will be to get jupyterlab/jupyterlab#11894 merged in JupyterLab, and released in |
name = "retro" | ||
app_name = "RetroLab" | ||
description = "RetroLab - A JupyterLab Distribution with a retro look and feel" | ||
class JupyterNotebookApp(NotebookConfigShimMixin, LabServerApp): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class needs to be named something else than NotebookApp
.
Otherwise the traits translation provided by notebook_shim
would try to convert for example NotebookApp.collaborative
to ServerApp.collaborative
, but collaborative does not exist on
ServerAppbut on
LabApp`.
$ jupyter notebook --no-browser
[C 2022-02-25 10:12:36.754 LabApp] Bad config encountered during initialization: Trait, expose_app_in_browser, not found.
cc @Zsailer to double check this is fine, which I believe it should, since JupyterNotebookApp
inherits from ServerApp
.
This can be tested on Binder: https://mybinder.org/v2/gh/jtpio/retrolab/notebook-repo?urlpath=tree The notebook-binder.mp4 |
cc @Zsailer if you would like to do a first round of review (or anyone else interested). Some UI tests are still a bit flaky (#341). I'm also planning to finish #352 first, and integrate the changes here. Then this branch (https://github.com/jtpio/retrolab/tree/notebook-repo) should be ready to be integrated in https://github.com/jupyter/notebook. There will still be some things to fix like the merge with existing files (readme, changelog...) but we can iterate there then. Hoping to open the PR in https://github.com/jupyter/notebook/ some time next week. |
Closing since the corresponding PR has been opened on the notebook repo: jupyter/notebook#6294 |
Opening this draft PR here for visibility, and to use the CI checks to make sure the renaming and other changes are correct. Also because
retrolab
/notebook 7
still lives in this current repo for now.Initial steps towards JEP 79: https://jupyter.org/enhancement-proposals/79-notebook-v7/notebook-v7.html
This might be rebased once #319 lands.
Changes
retrolab
tonotebook
NotebookApp
,INotebookShell
...@jupyter-notebook
scope (Update npm packages to the@jupyter-notebook
scope #313)nbclassic
dependency7.0.0a0
notebook
->jupyterlab
->nbclassic
->notebook<7
dependency cycle