Clear output outside the STFT #30

jurihock · Nov 17, 2023 · 6b5877f · 6b5877f
1 parent 0bb4cbc
commit 6b5877f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/cpp/StftPitchShift/STFT.h b/cpp/StftPitchShift/STFT.h
@@ -70,8 +70,6 @@ namespace stftpitchshift
     {
       const size_t samples = (std::min)(input.size(), output.size());
 
-      std::fill(output.begin(), output.end(), T(0)); // clear output #30
-
       if (chronometry)
       {
         struct

diff --git a/cpp/StftPitchShift/StftPitchShift.cpp b/cpp/StftPitchShift/StftPitchShift.cpp
@@ -114,6 +114,9 @@ void StftPitchShift::shiftpitch(
   const double quefrency,
   const double distortion)
 {
+  // preemptively clear output #30
+  std::fill(output.begin(), output.end(), float(0));
+
   StftPitchShiftCore<float> core(fft, framesize, hopsize, samplerate);
 
   core.factors(factors);
@@ -136,6 +139,9 @@ void StftPitchShift::shiftpitch(
   const double quefrency,
   const double distortion)
 {
+  // preemptively clear output #30
+  std::fill(output.begin(), output.end(), double(0));
+
   StftPitchShiftCore<double> core(fft, framesize, hopsize, samplerate);
 
   core.factors(factors);
-Original file line number
+Diff line change
@@ Expand Up / @@ -70,8 +70,6 @@ namespace stftpitchshift @@
         {
           const size_t samples = (std::min)(input.size(), output.size());
-          std::fill(output.begin(), output.end(), T(0)); // clear output #30
           if (chronometry)
           {
             struct
@@ Expand Down @@