Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: file movement for two fa attempts inside dashboard #1556

Merged
merged 5 commits into from
Oct 10, 2024
Merged

chore: file movement for two fa attempts inside dashboard #1556

merged 5 commits into from
Oct 10, 2024

Conversation

Riddhiagrawal001
Copy link
Contributor

@Riddhiagrawal001 Riddhiagrawal001 commented Oct 6, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Chore changes to introduce totp and recovery code attempts expired inside the dashboard .

Motivation and Context

How did you test it?

Change totp and regenerate recovery codes should work same

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@Riddhiagrawal001 Riddhiagrawal001 added the chore chore label Oct 6, 2024
@Riddhiagrawal001 Riddhiagrawal001 self-assigned this Oct 6, 2024
@Riddhiagrawal001 Riddhiagrawal001 requested a review from a team as a code owner October 6, 2024 14:55
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Oct 6, 2024 •
edited
Loading

Review changes with SemanticDiff.

@Riddhiagrawal001 Riddhiagrawal001 linked an issue Oct 6, 2024 that may be closed by this pull request
file movement for two fa attempts inside dashboard #1558
Closed
@prajwalnl0 prajwalnl0 added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit 4c720da Oct 10, 2024
9 checks passed
@prajwalnl0 prajwalnl0 deleted the totp-attempts-changes-pr-1 branch October 10, 2024 07:01
@github-actions github-actions bot added Closed Applied to issues or pull requests that have been successfully resolved or completed and removed chore chore labels Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PritishBudhiraja PritishBudhiraja PritishBudhiraja approved these changes

@JeevaRamu0104 JeevaRamu0104 JeevaRamu0104 approved these changes

Assignees

@Riddhiagrawal001 Riddhiagrawal001

Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

file movement for two fa attempts inside dashboard
4 participants
@Riddhiagrawal001 @PritishBudhiraja @JeevaRamu0104 @prajwalnl0