feat(helm): add pre-start and post-start hooks for installation analytics #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shailesh-714
changed the title
inventvenkat
changed the title
itsharshvb
approved these changes
Mar 28, 2025
inventvenkat
requested changes
Apr 1, 2025
| WEBHOOK_URL="https://hyperswitch.gateway.scarf.sh/$PLATFORM" | ||
|
|
||
| MAX_RETRIES=30 # Maximum attempts before exiting | ||
| SLEEP_INTERVAL=2 # Wait time in seconds |
There was a problem hiding this comment.
this variable is not used.
| VERSION="{{ .Chart.Version }}" | ||
| STATUS="" | ||
| SERVER_HEALTH_URL="http://hyperswitch-server:80/health" | ||
| HYPERSWITCH_URL="http://hyperswitch-server:80/health/ready" |
There was a problem hiding this comment.
Change the name to HYPERSWITCH_DEEP_HEALTH_URL
inventvenkat
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Added a webhook notifier for pre- and post-installation of
hyperswitch-helm. This webhook sends the following API call tohttps://hyperswitch.gateway.scarf.sh:The API calls include information about the platform(docker/helm/cdk), version and additional information about success/failure.
Motivation and Context
This change enables tracking of installation attempts, providing valuable insights into user adoption and setup experience. By monitoring success and failure rates, we can identify and resolve potential setup issues, ultimately improving user experience.
How did you test it?
WEBHOOK_URLinprestart-hook.yamlandpoststart-hook.yamlhelm install hypers-v1 . -n hyperswitchChecklist