Use inspect to remove the dependency on nix fork for flake-schemas
#277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`inspect` is used to inspect a flake output based on a schema. See: https://github.com/juspay/inspect
srid
reviewed
Sep 15, 2024
srid
reviewed
Sep 15, 2024
srid
reviewed
Sep 15, 2024
|
@srid |
It is disabled in Nix; this PR's failure is from devshell's |
srid
reviewed
Sep 18, 2024
| @@ -5,7 +5,7 @@ use super::core::om; | |||
| /// `om show` runs, and succeeds for a local flake. | |||
| #[test] | |||
| fn om_show_local() -> anyhow::Result<()> { | |||
| om()?.arg("show").arg(".").assert().success().stdout( | |||
| om()?.arg("show").arg("../..").assert().success().stdout( | |||
There was a problem hiding this comment.
nix flake show walks up the directory tree to find the flake, while nix eval doesn't
not still happy about the design of the upstream module. need to revisit.
|
intel mac builder is stuck for reason, 
|
|
I don't know what this entails, but we can do this after this PR is merged, which I'll do now. |
srid
reviewed
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #261
inspectis used to inspect a flake output based on a schema. See: https://github.com/juspay/inspectSee changes on the
juspay/inspectfork: juspay/inspect@279cfa5Todo:
nixosConfigurationsis shown ondarwin(This is necessary because we evaluate derivations only for the current system to avoid errors due to IFD. However, specific derivations can be skipped if they haveevalOnAllSystems = true;in their schema, which is the case for outputs like{nixos, darwin, home}Configurations.evalOnAllSystemsis supported in juspay/inspect@279cfa5. For more context, also see Useinspectto remove the dependency onnixfork for flake-schemas #277 (comment)) Done in 6303a7dSystemsListFlakeReftonix_rsand use it for thesystemsinput ofinspectflake