Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install files in a more CMake way #54

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

mshockwave
Copy link
Contributor

Such that we can designate the install destination via CMAKE_INSTALL_PREFIX.

Such that we can designate the install destination via
`CMAKE_INSTALL_PREFIX`.
@justanhduc
Copy link
Owner

Hey @mshockwave. Thanks a lot for the PR. It seems that the man folder is not automatically created, which causes the CIs to fail. Could you please send a fix for this?

Create `<build dir>/man1` to store the man page before running makeman.
@mshockwave
Copy link
Contributor Author

Hey @mshockwave. Thanks a lot for the PR. It seems that the man folder is not automatically created, which causes the CIs to fail. Could you please send a fix for this?

I just fixed that, finger crossed on CI 🤞

I didn't notice this issue previously because I always generate Ninja build files (cmake -G Ninja ...) rather than generating GNU Make, which is the default. And it seems like Ninja will create missing folders for you, how interesting!

@justanhduc justanhduc merged commit 1522ab0 into justanhduc:master Jan 19, 2024
8 checks passed
@justanhduc
Copy link
Owner

LGTM. Thanks @mshockwave!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants