feat!: add disabled and respectDisabledAttribute options #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add disabled option to disable the wave effect on an element - add respectDisabledAttribute option to respect the html disabled attribute on an element Resolves #543 BREAKING CHANGE: the disabled attr now disables the wave effect on the element BREAKING CHANGE: removed the ability to disable the wave effect by passing `false` to the directive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #543
BREAKING CHANGE: the disabled attr now disables the wave effect on the element
BREAKING CHANGE: removed the ability to disable the wave effect by passing
falseto the directive