This repository has been archived by the owner on Nov 6, 2023. It is now read-only.
Classes #15
Merged
Classes #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvdcf
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Em princípio está tudo bem, fica à vontade para dar pull request. Apesar disso, deixo umas sugestões abaixo que não são importantes:
- Nós temos de fazer a documentação Doxygen. Não tem de ser agora e tem tempo, mas se conseguires já, seria incrível;
- Para a possibilidade de o CSV estar defeituoso na data ou no tipo de aula, acho boa ideia incluir uma exceção em cada função a indicar que o argumento não é válido;
- Nas funções to_str, acho que não era uma má ideia usar switch cases em vez de ifs, mas é uma questão de preferência a este ponto.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.