modified: CHANGELOG.md

CHANGELOG.md

@@ -1,6 +1,7 @@
-## [5.0.56] - 2024-03-??
+## [5.0.56] - 2024-02-24
 
 * set the ZeroMQ port to 0 by default, hence assuming a single-server mode (the port can be specified in the _*config.ini*_ file)
+* corrected the P-V Diagram line length calculation inside a FORTRAN subroutine, added capacity checks to prevent potential out-of-bounds accesses
 
 ## [5.0.55] - 2024-02-22
 

src/fits.f90

@@ -8679,7 +8679,7 @@ recursive subroutine ws_pv_request(user) BIND(C, name='ws_pv_request')
       type(c_ptr) :: pid
       integer(kind=c_int) :: rc
 
-      integer :: frame, first, last, length, npoints, i, j, max_threads
+      integer :: frame, first, last, length, capacity, npoints, i, j, max_threads
       real :: dx, dy, dp, t, dt
       integer(c_int) :: x1, x2, y1, y2
       integer :: prev_x, prev_y, cur_x, cur_y
@@ -8762,8 +8762,8 @@ recursive subroutine ws_pv_request(user) BIND(C, name='ws_pv_request')
       print *, 'dx:', dx, 'dy:', dy, 'dp:', dp, 'dt:', dt
 
       ! over-allocate the points array
-      npoints = ceiling(2*dp)
-      allocate (points(2,npoints))
+      capacity = ceiling(2*dp)
+      allocate (points(2,capacity))
 
       ! first enumerate points along the line
       npoints = 0
@@ -8781,9 +8781,12 @@ recursive subroutine ws_pv_request(user) BIND(C, name='ws_pv_request')
          end if
 
          t = t + dt
+
+         ! break the loop if capacity is exceeded
+         if (npoints .ge. capacity) exit
       end do
 
-      print *, 'npoints:', npoints
+      print *, 'npoints:', npoints, 'capacity:', capacity
 
       ! there will be at least one point
       ! allocate the pv array using an appropriate astronomical orientation convention
@@ -8980,7 +8983,7 @@ subroutine get_pv_diagram(item, req, pixels, width, height, pmin, pmax, pmean, p
       type(c_ptr) :: pid
       integer(kind=c_int) :: rc
 
-      integer :: frame, first, last, length, i, j, max_threads
+      integer :: frame, first, last, length, i, j, max_threads, capacity
       real :: dx, dy, dp, t, dt
       integer(c_int) :: x1, x2, y1, y2
       integer :: prev_x, prev_y, cur_x, cur_y
@@ -9039,8 +9042,8 @@ subroutine get_pv_diagram(item, req, pixels, width, height, pmin, pmax, pmean, p
       print *, 'dx:', dx, 'dy:', dy, 'dp:', dp, 'dt:', dt
 
       ! over-allocate the points array
-      npoints = ceiling(2*dp)
-      allocate (points(2,npoints))
+      capacity = ceiling(2*dp)
+      allocate (points(2,capacity))
 
       ! first enumerate points along the line
       npoints = 0
@@ -9058,9 +9061,12 @@ subroutine get_pv_diagram(item, req, pixels, width, height, pmin, pmax, pmean, p
          end if
 
          t = t + dt
+
+         ! break the loop if capacity is exceeded
+         if (npoints .ge. capacity) exit
       end do
 
-      print *, 'npoints:', npoints
+      print *, 'npoints:', npoints, 'capacity:', capacity
 
       ! there will be at least one point
       ! allocate the pv array using an appropriate astronomical orientation convention

src/version.h

@@ -2,7 +2,7 @@
 
 #define VERSION_MAJOR 5
 #define VERSION_MINOR 0
-#define VERSION_SUB 55
+#define VERSION_SUB 56
 
 #define STR_HELPER(x) #x
 #define STR(x) STR_HELPER(x)