Wire integration tests into CI and add DinD sidecar

.egg-state/agent-outputs/integrator-output.json

@@ -1,92 +1,124 @@
 {
   "status": "pass",
   "phase": "implement",
-  "pipeline_id": "issue-850",
-  "issue": 850,
-  "summary": "Two-tier health check framework integration verified across both implementation phases. All tests pass, all cross-phase interfaces are correct, no regressions detected.",
-  "test_results": {
-    "health_check_tests": {
-      "passed": 419,
-      "failed": 0,
-      "skipped": 0,
-      "description": "All health check framework tests (types, tier1, tier2, context, runner, integration, lifecycle, tester coverage)"
+  "pipeline_id": "issue-647",
+  "issue": 647,
+  "summary": "Post-review integration verification complete. All 5 code review issues were addressed by the coder in commit bbcfd237. 101 DinD-specific tests pass, 6724 total tests pass. No regressions introduced. Lint and formatting clean.",
+  "review_feedback_verification": {
+    "issue_1_dind_container_leak": {
+      "status": "fixed",
+      "severity": "HIGH",
+      "detail": "container_spawner.py:398-558 restructured with outer try/except catching both ContainerSpawnError (line 522) and generic Exception (line 540). Both handlers call dind_manager.teardown() before re-raising. DinD provisioning (lines 356-385) moved inside the outer try block. Comment at lines 390-397 documents the cleanup contract.",
+      "tests": "test_tester_gaps.py::TestDindCleanupOnGatewayError (6 tests) covers: gateway session failure, container create failure, container start failure, teardown failure during error, session cleanup after DinD error, DinD not tracked after failure."
     },
-    "orchestrator_tests": {
-      "passed": 1169,
-      "failed": 3,
-      "skipped": 0,
-      "description": "Full orchestrator test suite. 3 failures are pre-existing in test_docker_client.py (unchanged files, same failures on origin/main)"
+    "issue_2_dind_auto_kill_timeout": {
+      "status": "fixed",
+      "severity": "HIGH",
+      "detail": "dind_manager.py:342-374 adds watchdog timer. DIND_MAX_LIFETIME_SECONDS=600 (line 59). _start_watchdog() called after healthy start (line 322). _watchdog_expired() calls teardown(). Watchdog cancelled in teardown() to prevent double-teardown. Max lifetime is configurable via constructor param (line 126).",
+      "tests": "test_tester_gaps.py::TestDindWatchdogTimer (8 tests) covers: watchdog starts on healthy start, not started when unhealthy, cancelled on teardown, disabled when max_lifetime=0, uses correct timeout, expired calls teardown, expired swallows teardown error, default is 600 seconds."
     },
-    "gateway_tests": {
-      "passed": 1523,
-      "failed": 0,
-      "skipped": 3,
-      "description": "Full gateway test suite - no regressions"
+    "issue_3_ci_path_filters_and_concurrency": {
+      "status": "fixed",
+      "severity": "MEDIUM",
+      "detail": "test-integration.yml has path filters (lines 6-14: gateway/**, orchestrator/**, shared/**, sandbox/**, integration_tests/**, pyproject.toml, uv.lock, workflow file itself) and concurrency group (lines 22-24). lint.yml has concurrency group (lines 13-15). test.yml has concurrency group (lines 13-15). All use cancel-in-progress: true.",
+      "tests": "test_tester_gaps.py::TestCIWorkflowConfiguration (7 tests) validates path filters, concurrency groups, image builds, cleanup steps, and autofix watcher config."
     },
-    "shared_tests": {
-      "passed": 84,
+    "issue_4_integration_test_enabled_wiring_gap": {
+      "status": "fixed",
+      "severity": "MEDIUM",
+      "detail": "Documented in docstrings: container_spawner.py:237-244 (spawn_agent_container param docs) and multi_agent.py:118-120 (executor constructor docs). Both explicitly note that production wiring is deferred to Phase 2 and currently only works through spawn_fn callback path.",
+      "tests": "test_tester_gaps.py::TestIntegrationTestEnabledProductionWiring (4 tests) verifies defaults and confirms production path does not pass the flag."
+    },
+    "issue_5_autofix_watcher_integration_tests": {
+      "status": "fixed",
+      "severity": "LOW",
+      "detail": "on-check-failure.yml:8 workflow_run.workflows list is ['Lint', 'Test'] — 'Integration Tests' removed per risk assessment R-4 recommendation.",
+      "tests": "test_tester_gaps.py::TestCIWorkflowConfiguration::test_autofix_watcher_does_not_include_integration_tests validates this."
+    }
+  },
+  "test_results": {
+    "dind_specific_tests": {
+      "passed": 101,
       "failed": 0,
       "skipped": 0,
-      "description": "Full shared module test suite - no regressions"
+      "files": [
+        "test_dind_manager.py (24 tests)",
+        "test_dind_manager_gaps.py (22 tests)",
+        "test_container_spawner_dind.py (19 tests)",
+        "test_multi_agent_dind.py (7 tests)",
+        "test_tester_gaps.py (29 tests)"
+      ],
+      "description": "All DinD-related unit tests pass including gap tests for cleanup, watchdog, CI configuration, and production wiring."
     },
-    "root_tests": {
-      "passed": 3744,
-      "failed": 0,
-      "skipped": 80,
-      "description": "Full root test suite including all components - no regressions"
+    "full_test_suite": {
+      "passed": 6724,
+      "failed": 26,
+      "skipped": 85,
+      "description": "Full test suite (tests/, gateway/tests/, orchestrator/tests/). All 26 failures are pre-existing on origin/main."
+    },
+    "modified_file_tests": {
+      "gateway_tests": {
+        "passed": 326,
+        "failed": 0,
+        "description": "gateway/tests/test_gateway.py — no regressions"
+      },
+      "pipeline_prompts": {
+        "status": "included in full suite",
+        "description": "orchestrator/tests/test_pipeline_prompts.py — passes"
+      }
     }
   },
-  "integration_checks": {
-    "types_interface": {
-      "status": "pass",
-      "detail": "Tier 2 agent inspector correctly imports and uses HealthCheck, HealthResult, HealthStatus, HealthAction, HealthTier, HealthTrigger from types.py"
+  "pre_existing_failures": [
+    {
+      "file": "tests/scripts/test_checks.py",
+      "count": 22,
+      "description": "ModuleNotFoundError: 'checks' is not a package. Import resolution issue unrelated to this PR. File not modified by this branch."
     },
-    "context_usage": {
-      "status": "pass",
-      "detail": "Agent inspector correctly uses PipelineHealthContext and all lazy-loaded methods (git_log, git_diff_stat, agent_outputs, contract, live_container_ids)"
+    {
+      "file": "orchestrator/tests/test_docker_client.py",
+      "count": 3,
+      "description": "Docker SDK (docker-py) not available in sandbox environment. TypeError when catching docker.errors.NotFound. File not modified by this branch."
     },
-    "runner_escalation": {
+    {
+      "file": "orchestrator/tests/test_models.py",
+      "count": 1,
+      "description": "test_all_roles expects 15 AgentRole values but 16 exist (REVIEWER_PLAN added). File not modified by this branch."
+    }
+  ],
+  "lint_results": {
+    "ruff_check": "pass",
+    "ruff_format": "pass",
+    "description": "All changed files (container_spawner.py, dind_manager.py, multi_agent.py, workflows) pass ruff check and format."
+  },
+  "integration_checks": {
+    "ci_workflow_triggers": {
       "status": "pass",
-      "detail": "Runner correctly handles Tier 1 then Tier 2 with escalation logic: WAVE_COMPLETE escalates on DEGRADED, PHASE_COMPLETE/ON_DEMAND always escalate, STARTUP/RUNTIME_TICK never escalate"
+      "detail": "pull_request triggers on lint.yml, test.yml, test-integration.yml. All use types: [opened, synchronize, reopened]."
     },
-    "routes_integration": {
+    "ci_image_builds": {
       "status": "pass",
-      "detail": "routes/health.py uses runner for ON_DEMAND checks. routes/phases.py gates phase advance on PHASE_COMPLETE checks with FAIL_PIPELINE blocking"
+      "detail": "test-integration.yml builds egg-gateway, egg-orchestrator, and mock-sandbox before running tests."
     },
-    "init_exports": {
+    "ci_cleanup": {
       "status": "pass",
-      "detail": "All __init__.py files in health_checks/, tier1/, tier2/ export needed symbols correctly"
+      "detail": "test-integration.yml cleanup step handles both compose stacks (docker-compose.yml and local_pipeline/docker-compose.yml)."
     },
-    "multi_agent_integration": {
+    "dind_lifecycle": {
       "status": "pass",
-      "detail": "multi_agent.py correctly calls health checks on wave completion with WAVE_COMPLETE trigger, breaks on FAIL_PIPELINE action"
+      "detail": "DindManager handles full lifecycle: startup with stale container removal, health polling, image preload, watchdog timer, idempotent teardown."
     },
-    "container_monitor_integration": {
+    "dind_error_handling": {
       "status": "pass",
-      "detail": "container_monitor.py integrates via set_health_check_runner, fires RUNTIME_TICK checks on container state changes"
+      "detail": "All error paths in container_spawner clean up DinD sidecar. ContainerSpawnError and generic Exception handlers both call teardown(). Watchdog provides safety net."
     },
-    "events_integration": {
+    "flag_propagation": {
       "status": "pass",
-      "detail": "events.py defines all health check event types (STARTED, COMPLETED, DEGRADED, FAILED) that runner emits"
+      "detail": "integration_test_enabled flows: MultiAgentExecutor -> spawn_fn env var -> TESTER role only. Production Docker path documented as Phase 2 deferral."
     },
-    "cli_initialization": {
+    "conftest_dind_awareness": {
       "status": "pass",
-      "detail": "cli.py registers all checks (4 Tier 1 + 1 Tier 2), stores runner on app.config, wires into container monitor, runs STARTUP checks"
+      "detail": "conftest.py detects DOCKER_HOST for DinD mode, skips redundant image builds via _image_exists() optimization."
     }
   },
-  "lint_results": {
-    "ruff_check": "pass",
-    "ruff_format": "pass",
-    "description": "All source and test files pass ruff check and format verification"
-  },
-  "pre_existing_issues": [
-    {
-      "file": "orchestrator/tests/test_docker_client.py",
-      "description": "3 test failures in test_docker_client.py (TestDockerClientConnection::test_is_connected_false, TestContainerCreation::test_create_container_image_not_found, TestContainerOperations::test_start_container_not_found). These are pre-existing on origin/main and unrelated to issue #850 changes."
-    }
-  ],
-  "files_changed": 36,
-  "lines_added_approx": 10802,
-  "integration_fixes_needed": 0,
-  "verdict": "All cross-phase integration points verified clean. No fixes required. The two-tier health check framework (phase-1: core + Tier 1, phase-2: Tier 2 agent inspector) is correctly integrated with the orchestrator lifecycle."
+  "verdict": "All 5 code review issues verified as fixed. 101 DinD tests and 6724 total tests pass. No regressions. Lint clean. Ready for PR merge."
 }