Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
d68dc9c
Initialize SDLC contract for issue #871
Feb 23, 2026
ac24d44
Add refine analysis for issue #871
Feb 23, 2026
582cc59
Add agent-design review verdict for issue #871 refine phase
Feb 23, 2026
7cd103b
Add refine review verdict for issue #871
Feb 23, 2026
00dfac2
Persist statefiles after refine phase
Feb 23, 2026
0e5bec9
Add architect analysis for issue #871: namespace .egg-state files per…
Feb 23, 2026
6befe4a
WIP: auto-commit uncommitted work (architect) [issue-871]
Feb 23, 2026
971149c
Add implementation plan for issue #871: namespace .egg-state files pe…
Feb 23, 2026
7207124
Add risk assessment for issue #871: namespace .egg-state files per-pi…
Feb 23, 2026
b36988b
WIP: auto-commit uncommitted work (task_planner) [issue-871]
Feb 23, 2026
d06896c
WIP: auto-commit uncommitted work (risk_analyst) [issue-871]
Feb 23, 2026
e597987
Add plan review verdict for issue #871: needs_revision
Feb 23, 2026
2fcfdae
Revised architect output: address plan review feedback for issue #871
Feb 23, 2026
98f9c67
WIP: auto-commit uncommitted work (architect) [issue-871]
Feb 23, 2026
0f0033e
Revised plan: address reviewer feedback on wrapper layer callsites
Feb 23, 2026
469dc1d
WIP: auto-commit uncommitted work (task_planner) [issue-871]
Feb 23, 2026
cdfc1c8
Risk assessment revision 2: identify plan draft sync gap and test sco…
Feb 23, 2026
b39ab27
WIP: auto-commit uncommitted work (risk_analyst) [issue-871]
Feb 23, 2026
b8d495e
Plan review: approved (revision 2)
Feb 23, 2026
503e214
Persist statefiles after plan phase
Feb 23, 2026
1d39296
Namespace .egg-state files per-pipeline to prevent merge conflicts
Feb 23, 2026
657b009
Add tests for namespaced .egg-state file paths
Feb 23, 2026
00ed715
Update docs and agent mode commands for namespaced filenames
Feb 23, 2026
747fb3a
Document agent-outputs namespacing and backward compat fallback
Feb 23, 2026
08627c1
Add gap-targeting tests for namespaced .egg-state file paths
Feb 23, 2026
fbf7999
Fix remaining hardcoded tester-output.json paths and lint issues
Feb 23, 2026
3f52e4d
Update implement phase check results: all passed
Feb 23, 2026
8f858da
Persist statefiles after implement phase
Feb 23, 2026
17fc1fa
Merge origin/main into egg/issue-871/work: resolve .egg-state conflicts
jwbron Feb 23, 2026
930c82c
Address review feedback: extract _pipeline_identifier helper
egg-reviewer[bot] Feb 23, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions .egg-state/agent-outputs/871-integrator-output.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
{
"status": "success",
"tests": {
"total": 6692,
"passed": 6692,
"failed": 0,
"skipped": 85
},
"lint": {
"status": "pass",
"issues_found": 3,
"issues_fixed": 3,
"details": "Removed unused pytest imports from test_handoffs_namespaced.py and test_orchestrator.py; fixed import sort order in test_handoffs_namespaced.py; reformatted 5 files via ruff format"
},
"integration_issues": {
"found": 2,
"fixed": 2,
"details": [
{
"file": "orchestrator/routes/pipelines.py",
"line": 2213,
"issue": "Hardcoded tester-output.json in _build_phase_prompt revision instructions not updated to use namespaced path",
"fix": "Updated to use f-string with {issue_number if issue_number is not None else pipeline_id}-tester-output.json"
},
{
"file": "orchestrator/routes/pipelines.py",
"line": 2810,
"issue": "Hardcoded tester-output.json in _build_phase_scoped_prompt revision checklist not updated to use namespaced path",
"fix": "Updated to use f-string with {pipeline.issue_number if pipeline.issue_number is not None else pipeline_id}-tester-output.json"
}
]
},
"regressions": {
"found": false,
"details": "All 6692 existing tests pass. No regressions detected."
},
"summary": "Integration verified successfully. The coder's implementation correctly namespaces .egg-state files per-pipeline to prevent merge conflicts. Two hardcoded tester-output.json references in prompt-building functions were missed by the coder and have been fixed by the integrator. All tests pass and lint is clean after fixes.",
"changes_reviewed": {
"core_library": "shared/egg_contracts/orchestrator.py - load_agent_output, save_agent_output, collect_handoff_data now accept identifier parameter with backward-compat fallback",
"orchestrator_handoffs": "orchestrator/handoffs.py - wrapper functions forward identifier to core library",
"pipeline_routes": "orchestrator/routes/pipelines.py - all callers pass identifier derived from issue_number or pipeline_id; prompt builders reference namespaced filenames",
"signals": "orchestrator/routes/signals.py - complete signal handler passes identifier when saving agent output",
"docs": "docs/architecture/orchestrator.md, docs/guides/agent-development.md, docs/guides/sdlc-pipeline.md - updated to reference namespaced filenames",
"agent_modes": "sandbox/.claude/commands/{coder,tester,documenter,integrator}-mode.md - updated output filename instructions",
"tests": "orchestrator/tests/test_handoffs_namespaced.py (new), shared/egg_contracts/tests/test_orchestrator.py (new), orchestrator/tests/test_pipeline_prompts.py (extended) - comprehensive coverage of namespaced paths, backward compat, edge cases"
},
"commit": "fbf79998f",
"acceptance_criteria": {
"all_egg_state_files_namespaced": true,
"no_globally_named_files_remain": true,
"backward_compatible_reader": true,
"documentation_updated": true
}
}
927 changes: 459 additions & 468 deletions .egg-state/agent-outputs/architect-output.json

Large diffs are not rendered by default.

420 changes: 205 additions & 215 deletions .egg-state/agent-outputs/risk_analyst-output.json

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions .egg-state/checks/implement-results.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@
{
"name": "lint",
"passed": true,
"output": "==> Ruff check...\nAll checks passed!\n==> Ruff format check...\n429 files already formatted\n==> Mypy...\nSuccess: no issues found in 118 source files\n==> Shellcheck...\n==> Custom checks... all passed"
"output": "==> Ruff check...\nAll checks passed!\n==> Ruff format check...\n430 files already formatted\n==> Mypy...\nSuccess: no issues found in 118 source files\n==> Shellcheck...\n==> Yamllint...\nSKIP: yamllint not installed\n==> Hadolint...\nSKIP: hadolint not installed\n==> Actionlint...\nSKIP: actionlint not installed\n==> Custom checks...\n bin-symlinks...\nOK: All 2 bin/ symlinks are valid\n claude-imports...\nWarning: host-services directory not found\n container-host-boundary...\nOK: No forbidden host-services imports found in sandbox\n container-paths...\nOK: No problematic sys.path patterns found\n docker-and-claude-invocations...\nOK: No docker/claude invocation violations found\n gh-cli-usage...\nWarning: host-services directory not found\n hardcoded-ports...\nOK: No hardcoded port numbers found\n llm-api-calls...\nOK: No direct LLM API usage found outside sandbox\n model-versions...\nOK: No non-alias Claude model references found\n reviewer-job-names...\nOK: All reviewer jobs use the required naming prefix\n workflow-secrets...\nOK: No untrusted script execution with secrets found in workflows"
},
{
"name": "test",
"passed": true,
"output": "=========== 6685 passed, 85 skipped, 4 warnings in 73.80s (0:01:13) ============\n\nFixed: 2 docker_client test failures caused by sys.modules mock pollution from test_checkpoint_discovery.py. Added early docker import in orchestrator/tests/conftest.py to ensure real docker module is in sys.modules before test collection."
"output": "==> Running unit tests...\npytest tests/ gateway/tests/ orchestrator/tests/ -v\n6692 passed, 85 skipped, 4 warnings in 73.24s (0:01:13)"
},
{
"name": "security",
Expand Down
Loading
Loading