[TASK] Fixed property promotion in MiddlewareTest Class

jweiland-net · Nov 22, 2024 · 505f8e0 · 505f8e0
1 parent d9c93b2
commit 505f8e0
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 18 deletions.
diff --git a/Classes/Helper/ReplacerHelper.php b/Classes/Helper/ReplacerHelper.php
@@ -14,6 +14,7 @@
 use JWeiland\Replacer\Configuration\ReplaceConfiguration;
 use JWeiland\Replacer\Enumeration\ConfigurationTypeEnumeration;
 use Psr\Http\Message\ServerRequestInterface;
+use TYPO3\CMS\Core\Http\ServerRequest;
 use TYPO3\CMS\Core\Utility\ArrayUtility;
 use TYPO3\CMS\Core\Utility\Exception\MissingArrayPathException;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
@@ -23,14 +24,7 @@
  */
 class ReplacerHelper
 {
-    protected TypoScriptHelper $typoScriptHelper;
-
-    protected ServerRequestInterface $request;
-
-    public function __construct(TypoScriptHelper $typoScriptHelper)
-    {
-        $this->typoScriptHelper = $typoScriptHelper;
-    }
+    public function __construct(protected TypoScriptHelper $typoScriptHelper) {}
 
     /**
      * Search and replace text from $contentToReplace

diff --git a/Classes/Helper/TypoScriptHelper.php b/Classes/Helper/TypoScriptHelper.php
@@ -12,6 +12,8 @@
 namespace JWeiland\Replacer\Helper;
 
 use Psr\Http\Message\ServerRequestInterface;
+use TYPO3\CMS\Core\Utility\GeneralUtility;
+use TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer;
 
 class TypoScriptHelper
 {

diff --git a/Classes/Middleware/ReplaceContentMiddleware.php b/Classes/Middleware/ReplaceContentMiddleware.php
@@ -28,12 +28,7 @@
  */
 class ReplaceContentMiddleware implements MiddlewareInterface
 {
-    private ReplacerHelper $replacerHelper;
-
-    public function __construct(ReplacerHelper $replacerHelper)
-    {
-        $this->replacerHelper = $replacerHelper;
-    }
+    public function __construct(protected ReplacerHelper $replacerHelper) {}
 
     public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
     {
@@ -55,10 +50,7 @@ protected function getContentObjectRenderer(ServerRequestInterface $request): Co
         $tsfeController = $request->getAttribute('frontend.controller');
 
         // Create a new instance of ContentObjectRenderer
-        $cObj = GeneralUtility::makeInstance(ContentObjectRenderer::class);
-
-        // Associate the ContentObjectRenderer with the TypoScriptFrontendController
-        $cObj->setFrontendController($tsfeController);
+        $cObj = GeneralUtility::makeInstance(ContentObjectRenderer::class, $tsfeController);
 
         // Set the request in the ContentObjectRenderer
         $cObj->setRequest($request);