Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/html response not set #131

Merged
merged 8 commits into from
May 31, 2024
Merged

Conversation

hojalatheef
Copy link
Contributor

No description provided.

@hojalatheef hojalatheef requested a review from sfroemkenjw May 21, 2024 13:25
@hojalatheef hojalatheef self-assigned this May 21, 2024
@hojalatheef hojalatheef force-pushed the bugfix/html-response-not-set branch from d9c6ee9 to fcd0c56 Compare May 21, 2024 13:27
Copy link
Contributor

@sfroemkenjw sfroemkenjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hojalatheef

after registering I gor a confirmation mail. Please click the approve link. You will get a second mail. Please click the decline link. The resulting page shows an record not found error. Can you please have a look?

@hojalatheef
Copy link
Contributor Author

Hi @sfroemkenjw You're right there was a huge bug in reservation cancellation the table name was incorrect because of a spelling error. I fixed that now and tested the workflow below.

Workflow 1

  1. Reserve a facility from frontend
  2. Got Confirmation Email for Admin
  3. Confirm the Reservation by Admin
  4. Got Confirmation Email for Reserved User
  5. Try Cancelling the Order
  6. Order Cancelled

Workflow 2

  1. Reserve a facility from frontend
  2. Got Confirmation Email for Admin
  3. Cancel Reservation By Admin
  4. Got Cancellation Email for Reserved User

@sfroemkenjw
Copy link
Contributor

yourext Muhahaha :D

@sfroemkenjw sfroemkenjw merged commit 246e443 into main May 31, 2024
3 checks passed
@sfroemkenjw sfroemkenjw deleted the bugfix/html-response-not-set branch May 31, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants